Patchwork data: klog.json: set _DOS error to low as kernel workarounds it (LP#1250764)

login
register
mail settings
Submitter Alex Hung
Date Nov. 20, 2013, 9:22 a.m.
Message ID <1384939339-23157-1-git-send-email-alex.hung@canonical.com>
Download mbox | patch
Permalink /patch/292695/
State Rejected
Headers show

Comments

Alex Hung - Nov. 20, 2013, 9:22 a.m.
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 data/klog.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Colin King - Nov. 20, 2013, 9:27 a.m.
On 20/11/13 09:22, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  data/klog.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/data/klog.json b/data/klog.json
> index 5d18c01..9bd7be5 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -5139,7 +5139,7 @@
>    },
>    {
>     "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
> +   "log_level": "LOG_LEVEL_LOW",
>     "tag": "FWTS_TAG_ACPI",
>     "pattern": ".*defines _DOD but not _DOS",
>     "advice": "ACPI Method _DOD (Enumerate all devices attached to display adapter) is defined but we should also have _DOS (Enable\/Disable output switching) defined but it's been omitted. This can cause display switching issues.",
> 
I believe the kernel now handles this, so perhaps the advice needs to be
updated too (does it cause display switching issues anymore)?  If not,
we can remove that last sentence.

Colin
Alex Hung - Nov. 20, 2013, 9:37 a.m.
Thanks, I will re-work on the patch

On Wed, Nov 20, 2013 at 5:27 PM, Colin Ian King
<colin.king@canonical.com> wrote:
> On 20/11/13 09:22, Alex Hung wrote:
>> Signed-off-by: Alex Hung <alex.hung@canonical.com>
>> ---
>>  data/klog.json | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/data/klog.json b/data/klog.json
>> index 5d18c01..9bd7be5 100644
>> --- a/data/klog.json
>> +++ b/data/klog.json
>> @@ -5139,7 +5139,7 @@
>>    },
>>    {
>>     "compare_mode": "regex",
>> -   "log_level": "LOG_LEVEL_HIGH",
>> +   "log_level": "LOG_LEVEL_LOW",
>>     "tag": "FWTS_TAG_ACPI",
>>     "pattern": ".*defines _DOD but not _DOS",
>>     "advice": "ACPI Method _DOD (Enumerate all devices attached to display adapter) is defined but we should also have _DOS (Enable\/Disable output switching) defined but it's been omitted. This can cause display switching issues.",
>>
> I believe the kernel now handles this, so perhaps the advice needs to be
> updated too (does it cause display switching issues anymore)?  If not,
> we can remove that last sentence.
>
> Colin
>
> --
> fwts-devel mailing list
> fwts-devel@lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel

Patch

diff --git a/data/klog.json b/data/klog.json
index 5d18c01..9bd7be5 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -5139,7 +5139,7 @@ 
   },
   {
    "compare_mode": "regex",
-   "log_level": "LOG_LEVEL_HIGH",
+   "log_level": "LOG_LEVEL_LOW",
    "tag": "FWTS_TAG_ACPI",
    "pattern": ".*defines _DOD but not _DOS",
    "advice": "ACPI Method _DOD (Enumerate all devices attached to display adapter) is defined but we should also have _DOS (Enable\/Disable output switching) defined but it's been omitted. This can cause display switching issues.",