diff mbox

patch PLUGIN_HEADER_FILE event for tracing of header inclusions.

Message ID 1384896773.11868.10.camel@glinka.lesours
State New
Headers show

Commit Message

Basile Starynkevitch Nov. 19, 2013, 9:32 p.m. UTC 
On Tue, 2013-11-19 at 20:33 +0100, Dominique Dhumieres wrote:
> > Thanks: Committed revision 205038.
> 
> This seems to break several g++ tests: see http://gcc.gnu.org/ml/gcc-testresults/2013-11/msg01482.html
> On x86_64-apple-darwin13, the ICE is

I would guess that the following trivial patch should correct that:

##### patch against svn rev 205052
#####

If that patch correct the bug, I guess that I could apply it under the
"obvious bugfix" rule. Could you check that it works on your MacOSX?

Apologies for my mistake.

Thanks

Comments

Dominique d'Humières Nov. 19, 2013, 9:45 p.m. UTC | #1 
Basile,

http://gcc.gnu.org/ml/gcc-testresults/2013-11/msg01482.html is for
x86_64-unknown-linux-gnu. However I cannot infer from the pointer
what is the ICE. Nevertheless I'll try your patch.

Thanks for the answer.

Dominique
Dominique d'Humières Nov. 19, 2013, 9:59 p.m. UTC | #2 
Basile,

The patch fixes most of the plugin failures except:

FAIL: g++.dg/plugin/selfassign.c compilation

The error is

/opt/gcc/work/gcc/testsuite/g++.dg/plugin/selfassign.c: In function 'void warn_self_assign(gimple)':
/opt/gcc/work/gcc/testsuite/g++.dg/plugin/selfassign.c:227:75: error: 'maybe_get_identifier' was not declared in this scope
       if (fdecl && (DECL_NAME (fdecl) == maybe_get_identifier ("operator=")))

Note that the test fails also on linux.

TIA

Dominique
diff mbox

Patch

Index: gcc/plugin.c
===================================================================
--- gcc/plugin.c	(revision 205052)
+++ gcc/plugin.c	(working copy)
@@ -529,6 +529,7 @@  invoke_plugin_callbacks_full (int event, void *gcc
       case PLUGIN_EARLY_GIMPLE_PASSES_START:
       case PLUGIN_EARLY_GIMPLE_PASSES_END:
       case PLUGIN_NEW_PASS:
+      case PLUGIN_INCLUDE_FILE:
         {
           /* Iterate over every callback registered with this event and
              call it.  */