diff mbox

expr: log: fixed error in nft_rule_expr_parse

Message ID 1384862476-3413-1-git-send-email-anarey@gmail.com
State Accepted
Headers show

Commit Message

Ana Rey Nov. 19, 2013, 12:01 p.m. UTC 
I fix it by allocating the correct value.
---
 src/expr/log.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Eric Leblond Nov. 19, 2013, 7:09 p.m. UTC | #1 
Hi,

Good catch. ACK.

Small thing, please modify the subject prefix so we know what is the
target of this patch. For example, use [libnftables PATCH] instead of
[PATCH]. You can use --subject-prefix of git to do so.

On Tue, 2013-11-19 at 13:01 +0100, Ana Rey wrote:
> I fix it by allocating the correct value.
> ---
>  src/expr/log.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/expr/log.c b/src/expr/log.c
> index 2d3e0cf..495c1bd 100644
> --- a/src/expr/log.c
> +++ b/src/expr/log.c
> @@ -142,7 +142,7 @@ nft_rule_expr_log_parse(struct nft_rule_expr *e, struct nlattr *attr)
>  			xfree(log->prefix);
>  
>  		log->prefix = strdup(mnl_attr_get_str(tb[NFTA_LOG_PREFIX]));
> -		e->flags |= (1 << NFT_EXPR_LOG_GROUP);
> +		e->flags |= (1 << NFT_EXPR_LOG_PREFIX);
>  	}
>  	if (tb[NFTA_LOG_GROUP]) {
>  		log->group = ntohs(mnl_attr_get_u16(tb[NFTA_LOG_GROUP]));

BR,
Pablo Neira Ayuso Nov. 19, 2013, 8:11 p.m. UTC | #2 
On Tue, Nov 19, 2013 at 01:01:16PM +0100, Ana Rey wrote:
> I fix it by allocating the correct value.

Applied, thanks Ana.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/src/expr/log.c b/src/expr/log.c
index 2d3e0cf..495c1bd 100644
--- a/src/expr/log.c
+++ b/src/expr/log.c
@@ -142,7 +142,7 @@  nft_rule_expr_log_parse(struct nft_rule_expr *e, struct nlattr *attr)
 			xfree(log->prefix);
 
 		log->prefix = strdup(mnl_attr_get_str(tb[NFTA_LOG_PREFIX]));
-		e->flags |= (1 << NFT_EXPR_LOG_GROUP);
+		e->flags |= (1 << NFT_EXPR_LOG_PREFIX);
 	}
 	if (tb[NFTA_LOG_GROUP]) {
 		log->group = ntohs(mnl_attr_get_u16(tb[NFTA_LOG_GROUP]));