Patchwork [1/2] alsa/soc: Fix typo in MPC5200 PSC AC97 driver Kconfig

login
register
mail settings
Submitter Grant Likely
Date June 28, 2009, 7:41 a.m.
Message ID <20090628074109.26905.9927.stgit@localhost.localdomain>
Download mbox | patch
Permalink /patch/29231/
State Not Applicable
Delegated to: Benjamin Herrenschmidt
Headers show

Comments

Grant Likely - June 28, 2009, 7:41 a.m.
From: Grant Likely <grant.likely@secretlab.ca>

ALSA SoC drivers should be specify SND_SOC_AC97_BUS instead, not AC97_BUS.
Without SND_SOC_AC97_BUS defined, an AC97 device will not get correctly
registered on the AC97 bus, which prevents thinks like the WM9712
touchscreen driver from getting probed.

Tested against 2.6.31-rc1.

Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---

 sound/soc/fsl/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Jon Smirl - June 28, 2009, 6:06 p.m.
On Sun, Jun 28, 2009 at 3:41 AM, Grant Likely<grant.likely@secretlab.ca> wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
>
> ALSA SoC drivers should be specify SND_SOC_AC97_BUS instead, not AC97_BUS.
> Without SND_SOC_AC97_BUS defined, an AC97 device will not get correctly
> registered on the AC97 bus, which prevents thinks like the WM9712
> touchscreen driver from getting probed.
>
> Tested against 2.6.31-rc1.
>
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>

Acked-by: Jon Smirl <jonsmirl@gmail.com>

> ---
>
>  sound/soc/fsl/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> index 5dbebf8..5661876 100644
> --- a/sound/soc/fsl/Kconfig
> +++ b/sound/soc/fsl/Kconfig
> @@ -33,7 +33,7 @@ config SND_SOC_MPC5200_I2S
>  config SND_SOC_MPC5200_AC97
>        tristate "Freescale MPC5200 PSC in AC97 mode driver"
>        depends on PPC_MPC52xx && PPC_BESTCOMM
> -       select AC97_BUS
> +       select SND_SOC_AC97_BUS
>        select SND_MPC52xx_DMA
>        select PPC_BESTCOMM_GEN_BD
>        help
>
>
Mark Brown - June 29, 2009, 9:35 a.m.
On Sun, Jun 28, 2009 at 01:41:52AM -0600, Grant Likely wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
> 
> ALSA SoC drivers should be specify SND_SOC_AC97_BUS instead, not AC97_BUS.

Applied both.

Patch

diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index 5dbebf8..5661876 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -33,7 +33,7 @@  config SND_SOC_MPC5200_I2S
 config SND_SOC_MPC5200_AC97
 	tristate "Freescale MPC5200 PSC in AC97 mode driver"
 	depends on PPC_MPC52xx && PPC_BESTCOMM
-	select AC97_BUS
+	select SND_SOC_AC97_BUS
 	select SND_MPC52xx_DMA
 	select PPC_BESTCOMM_GEN_BD
 	help