From patchwork Mon Nov 18 12:13:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 292046 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id F25522C00C8 for ; Mon, 18 Nov 2013 23:13:26 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751288Ab3KRMNY (ORCPT ); Mon, 18 Nov 2013 07:13:24 -0500 Received: from mail-ee0-f42.google.com ([74.125.83.42]:53991 "EHLO mail-ee0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751266Ab3KRMNX (ORCPT ); Mon, 18 Nov 2013 07:13:23 -0500 Received: by mail-ee0-f42.google.com with SMTP id e52so2487915eek.29 for ; Mon, 18 Nov 2013 04:13:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :content-type; bh=N/x379A/9TCN87e2hxdl/kHkT+GAd+UNYa0GEe8Yu3w=; b=SEeQMKq1KtJViG0Na4hsQU3V5kYt01G2fOLY8Al0yV/mcPbXYDeKG1A6NEBPzjDLkr ejkqRmLVe8GE70kuk1EsF+zPsDbMElAIFD6Alu8jZPM8TmtW5RDJgiMYKibqcDLFt3yy Hh9dOw/3EetZT0RXhBLBB9gGmCLdrH2Y0ErVLyKQb/9dmlgeJhSVAWsmcpXe1ha1po6H VjNs984rYMAw5AcKR8i/nuo9V2vdf6HLoR+znRbE4hCbTTF+cdaw/POWI7SSf3bW1Sep Tuo5KjSKXTXCEJQ7bOB8DFYS/9I0z0HkkGjk8cpNZ0fwtM71Lc0A0HGeKGIJYLuE0QoH AfGw== X-Gm-Message-State: ALoCoQl11+dX44qwGztImFXnCt4XsutddRYec3pPeHkvkfLHZvyvikBmqNthbK3TCsRpv/39ji6k X-Received: by 10.14.1.130 with SMTP id 2mr21351504eed.24.1384776801578; Mon, 18 Nov 2013 04:13:21 -0800 (PST) Received: from localhost (nat-63.starnet.cz. [178.255.168.63]) by mx.google.com with ESMTPSA id 44sm37282240eek.5.2013.11.18.04.13.20 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Mon, 18 Nov 2013 04:13:20 -0800 (PST) From: Michal Simek To: linux-kernel@vger.kernel.org, monstr@monstr.eu, wsa@the-dreams.de, joe@perches.com Cc: Kedareswara rao Appana , Jean Delvare , Peter Korsgaard , Kedareswara rao Appana , linux-i2c@vger.kernel.org Subject: [PATCH v4 1/3] i2c: xilinx: Fix i2c checkpatch warnings Date: Mon, 18 Nov 2013 13:13:07 +0100 Message-Id: <04a1a7e01e2f3ff132658b7246ef32e74c73aa29.1384776761.git.michal.simek@xilinx.com> X-Mailer: git-send-email 1.8.2.3 Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org From: Kedareswara rao Appana Code changes to fix checkpatch warnings listed below. - WARNING: please, no space before tabs - WARNING: quoted string split across lines Signed-off-by: Kedareswara rao Appana Signed-off-by: Michal Simek --- Changes in v4: - Get back full dev_dbg message Changes in v3: None Changes in v2: - It is checkpatch warnings not sparse - Extend patch description with checkpatch warnings Tested by: ./scripts/checkpatch.pl -f drivers/i2c/busses/i2c-xiic.c --- drivers/i2c/busses/i2c-xiic.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) -- 1.8.2.3 diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 4c8b368..4d5c79e 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -68,7 +68,7 @@ struct xiic_i2c { struct i2c_adapter adap; struct i2c_msg *tx_msg; spinlock_t lock; - unsigned int tx_pos; + unsigned int tx_pos; unsigned int nmsgs; enum xilinx_i2c_state state; struct i2c_msg *rx_msg; @@ -271,8 +271,8 @@ static void xiic_read_rx(struct xiic_i2c *i2c) bytes_in_fifo = xiic_getreg8(i2c, XIIC_RFO_REG_OFFSET) + 1; - dev_dbg(i2c->adap.dev.parent, "%s entry, bytes in fifo: %d, msg: %d" - ", SR: 0x%x, CR: 0x%x\n", + dev_dbg(i2c->adap.dev.parent, + "%s entry, bytes in fifo: %d, msg: %d, SR: 0x%x, CR: 0x%x\n", __func__, bytes_in_fifo, xiic_rx_space(i2c), xiic_getreg8(i2c, XIIC_SR_REG_OFFSET), xiic_getreg8(i2c, XIIC_CR_REG_OFFSET)); @@ -339,9 +339,10 @@ static void xiic_process(struct xiic_i2c *i2c) ier = xiic_getreg32(i2c, XIIC_IIER_OFFSET); pend = isr & ier; - dev_dbg(i2c->adap.dev.parent, "%s entry, IER: 0x%x, ISR: 0x%x, " - "pend: 0x%x, SR: 0x%x, msg: %p, nmsgs: %d\n", - __func__, ier, isr, pend, xiic_getreg8(i2c, XIIC_SR_REG_OFFSET), + dev_dbg(i2c->adap.dev.parent, "%s: IER: 0x%x, ISR: 0x%x, pend: 0x%x\n", + __func__, ier, isr, pend); + dev_dbg(i2c->adap.dev.parent, "%s: SR: 0x%x, msg: %p, nmsgs: %d\n", + __func__, xiic_getreg8(i2c, XIIC_SR_REG_OFFSET), i2c->tx_msg, i2c->nmsgs); /* Do not processes a devices interrupts if the device has no @@ -541,9 +542,10 @@ static void xiic_start_send(struct xiic_i2c *i2c) xiic_irq_clr(i2c, XIIC_INTR_TX_ERROR_MASK); - dev_dbg(i2c->adap.dev.parent, "%s entry, msg: %p, len: %d, " - "ISR: 0x%x, CR: 0x%x\n", - __func__, msg, msg->len, xiic_getreg32(i2c, XIIC_IISR_OFFSET), + dev_dbg(i2c->adap.dev.parent, "%s entry, msg: %p, len: %d", + __func__, msg, msg->len); + dev_dbg(i2c->adap.dev.parent, "%s entry, ISR: 0x%x, CR: 0x%x\n", + __func__, xiic_getreg32(i2c, XIIC_IISR_OFFSET), xiic_getreg8(i2c, XIIC_CR_REG_OFFSET)); if (!(msg->flags & I2C_M_NOSTART)) {