diff mbox

libcacard/cac: Remove unused statement (value stored is never read)

Message ID 1384722683-17205-1-git-send-email-sw@weilnetz.de
State Accepted
Headers show

Commit Message

Stefan Weil Nov. 17, 2013, 9:11 p.m. UTC 
Warning from ccc-analyzer:

libcacard/cac.c:192:13: warning: Value stored to 'ret' is never read
            ret = VCARD_DONE;
            ^     ~~~~~~~~~~

Here 'ret' is assigned a value inside of a switch statement and also after
that switch statement.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---

This patch is not needed for 1.7 (although I think that it is safe).

 libcacard/cac.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Michael Tokarev Dec. 2, 2013, 5:07 p.m. UTC | #1 
18.11.2013 01:11, Stefan Weil wrote:
> Warning from ccc-analyzer:
> 
> libcacard/cac.c:192:13: warning: Value stored to 'ret' is never read
>             ret = VCARD_DONE;
>             ^     ~~~~~~~~~~
> 
> Here 'ret' is assigned a value inside of a switch statement and also after
> that switch statement.

Applied to trivial patches, thank you!

/mjt
diff mbox

Patch

diff --git a/libcacard/cac.c b/libcacard/cac.c
index 7a06b5a..74ef3e3 100644
--- a/libcacard/cac.c
+++ b/libcacard/cac.c
@@ -189,7 +189,6 @@  cac_applet_pki_process_apdu(VCard *card, VCardAPDU *apdu,
             pki_applet->sign_buffer = sign_buffer;
             pki_applet->sign_buffer_len = size;
             *response = vcard_make_response(VCARD7816_STATUS_SUCCESS);
-            ret = VCARD_DONE;
             break;
         case 0x00:
             /* we now have the whole buffer, do the operation, result will be