Message ID | 20131117111409.GB23153@zirkel.wertarbyte.de |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show |
Hello. On 17-11-2013 15:14, Stefan Tomanek wrote: > Reported-by: Daniel Golle <daniel.golle@gmail.com> > Tested-by: Daniel Golle <daniel.golle@gmail.com> > Signed-off-by: Stefan Tomanek <stefan.tomanek@wertarbyte.de> > --- > net/ipv4/fib_rules.c | 4 +++- > net/ipv6/fib6_rules.c | 5 ++++- > 2 files changed, 7 insertions(+), 2 deletions(-) > diff --git a/net/ipv4/fib_rules.c b/net/ipv4/fib_rules.c > index 523be38..4e1c1e5 100644 > --- a/net/ipv4/fib_rules.c > +++ b/net/ipv4/fib_rules.c > @@ -104,7 +104,9 @@ errout: > static bool fib4_rule_suppress(struct fib_rule *rule, struct fib_lookup_arg *arg) > { > struct fib_result *result = (struct fib_result *) arg->result; > - struct net_device *dev = result->fi->fib_dev; > + struct net_device *dev = NULL; Please leave empty line after declarations, like it was before your patch. > + if (result->fi) > + dev = result->fi->fib_dev; > > /* do not accept result if the route does > * not meet the required prefix length > diff --git a/net/ipv6/fib6_rules.c b/net/ipv6/fib6_rules.c > index e275916..43e45b5 100644 > --- a/net/ipv6/fib6_rules.c > +++ b/net/ipv6/fib6_rules.c > @@ -122,7 +122,10 @@ out: > static bool fib6_rule_suppress(struct fib_rule *rule, struct fib_lookup_arg *arg) > { > struct rt6_info *rt = (struct rt6_info *) arg->result; > - struct net_device *dev = rt->rt6i_idev->dev; > + struct net_device *dev = NULL; Same here. > + if (rt->rt6i_idev) > + dev = rt->rt6i_idev->dev; > + WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ipv4/fib_rules.c b/net/ipv4/fib_rules.c index 523be38..4e1c1e5 100644 --- a/net/ipv4/fib_rules.c +++ b/net/ipv4/fib_rules.c @@ -104,7 +104,9 @@ errout: static bool fib4_rule_suppress(struct fib_rule *rule, struct fib_lookup_arg *arg) { struct fib_result *result = (struct fib_result *) arg->result; - struct net_device *dev = result->fi->fib_dev; + struct net_device *dev = NULL; + if (result->fi) + dev = result->fi->fib_dev; /* do not accept result if the route does * not meet the required prefix length diff --git a/net/ipv6/fib6_rules.c b/net/ipv6/fib6_rules.c index e275916..43e45b5 100644 --- a/net/ipv6/fib6_rules.c +++ b/net/ipv6/fib6_rules.c @@ -122,7 +122,10 @@ out: static bool fib6_rule_suppress(struct fib_rule *rule, struct fib_lookup_arg *arg) { struct rt6_info *rt = (struct rt6_info *) arg->result; - struct net_device *dev = rt->rt6i_idev->dev; + struct net_device *dev = NULL; + if (rt->rt6i_idev) + dev = rt->rt6i_idev->dev; + /* do not accept result if the route does * not meet the required prefix length */