From patchwork Fri Nov 15 22:05:42 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 291707 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 01A7E2C0096 for ; Sat, 16 Nov 2013 09:06:44 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=DnIY1ptrFhNT71GUJ 8c8RQ5oB18LYOIgU0mg59FXI4HPYdQ0NjksYkrrINPnBP4uFApAYpk2fgacRWrmm +WphPgPEgvc8YFTEtja6zksEwLBAUz3NyJYJQZhOmZo+AyxQtkgjp761oB8zFgk8 ZTpVPDuJkH7CAqthDj2mgLDtF4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=h3QkO97/WcD/uEtzTnU+jJ/ /o20=; b=gRCDy9qRSdpI5S+glweJ+mNWToifSECNycEki/g/4agpi/lv/r2WLAs CKtRXB8FN4XhUN8PmdVY8DvBsNX4JqDyRD0uece9sKG0UK0E2ruLZ6QMxQVpBRU2 1ds6Cajf1iUBS/TVIHRj+/WaSSh/5HHadEGVpYUjqfxh9BBYNoM4= Received: (qmail 17773 invoked by alias); 15 Nov 2013 22:05:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 17742 invoked by uid 89); 15 Nov 2013 22:05:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.5 required=5.0 tests=AWL, BAYES_50, RDNS_NONE, SPF_HELO_PASS, SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Nov 2013 22:05:52 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAFM5ihQ012480 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 15 Nov 2013 17:05:45 -0500 Received: from reynosa.quesejoda.com (vpn-56-14.rdu2.redhat.com [10.10.56.14]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rAFM5hZM023576; Fri, 15 Nov 2013 17:05:43 -0500 Message-ID: <52869AB6.7070709@redhat.com> Date: Fri, 15 Nov 2013 15:05:42 -0700 From: Aldy Hernandez User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Jakub Jelinek CC: Jason Merrill , gcc-patches , "Iyer, Balaji V" Subject: Re: PING: Fwd: Re: [patch] implement Cilk Plus simd loops on trunk References: <52618287.8010705@redhat.com> <52740D59.50104@redhat.com> <5284FF25.7020401@redhat.com> <20131114170553.GD27813@tucnak.zalov.cz> <52850AB6.2070408@redhat.com> <20131114180147.GE27813@tucnak.zalov.cz> <5285790E.9050000@redhat.com> <20131115073757.GA892@tucnak.redhat.com> <52863CB4.50900@redhat.com> <528695CD.5080705@redhat.com> <20131115214950.GS892@tucnak.redhat.com> In-Reply-To: <20131115214950.GS892@tucnak.redhat.com> > Why all this, and not keep everything but > GF_OMP_FOR_KIND_SIMD and GF_OMP_FOR_KIND_DISTRIBUTE > as they were, and just use: > GF_OMP_FOR_KIND_DISTIRBUTE = 1 << 0, > GF_OMP_FOR_KIND_SIMD = 2 << 0, > GF_OMP_FOR_KIND_CILKSIMD = 3 << 0, Sounds good. Testing the following patch against my previous patch which had already been committed. If there are no regressions, I will commit. Aldy commit a729e47afaedcc474aeaacbca5f59b3f1bae5a8c Author: Aldy Hernandez Date: Fri Nov 15 15:01:55 2013 -0700 * gimple.h (enum gf_mask): Change the ordering of GF_OMP_* bits. diff --git a/gcc/gimple.h b/gcc/gimple.h index c7cb9f7..e675b07 100644 --- a/gcc/gimple.h +++ b/gcc/gimple.h @@ -102,13 +102,13 @@ enum gf_mask { GF_CALL_ALLOCA_FOR_VAR = 1 << 5, GF_CALL_INTERNAL = 1 << 6, GF_OMP_PARALLEL_COMBINED = 1 << 0, - GF_OMP_FOR_KIND_MASK = 7, + GF_OMP_FOR_KIND_MASK = 3 << 0, GF_OMP_FOR_KIND_FOR = 0 << 0, + GF_OMP_FOR_KIND_DISTRIBUTE = 1 << 0, GF_OMP_FOR_KIND_SIMD = 2 << 0, GF_OMP_FOR_KIND_CILKSIMD = 3 << 0, - GF_OMP_FOR_KIND_DISTRIBUTE = 1 << 2, - GF_OMP_FOR_COMBINED = 1 << 3, - GF_OMP_FOR_COMBINED_INTO = 1 << 4, + GF_OMP_FOR_COMBINED = 1 << 2, + GF_OMP_FOR_COMBINED_INTO = 1 << 3, GF_OMP_TARGET_KIND_MASK = 3 << 0, GF_OMP_TARGET_KIND_REGION = 0 << 0, GF_OMP_TARGET_KIND_DATA = 1 << 0,