PING: Fwd: Re: [patch] implement Cilk Plus simd loops on trunk
diff mbox

Message ID 52869AB6.7070709@redhat.com
State New
Headers show

Commit Message

Aldy Hernandez Nov. 15, 2013, 10:05 p.m. UTC
> Why all this, and not keep everything but
> GF_OMP_FOR_KIND_SIMD and GF_OMP_FOR_KIND_DISTRIBUTE
> as they were, and just use:
>     GF_OMP_FOR_KIND_DISTIRBUTE = 1 << 0,
>     GF_OMP_FOR_KIND_SIMD       = 2 << 0,
>     GF_OMP_FOR_KIND_CILKSIMD   = 3 << 0,

Sounds good.  Testing the following patch against my previous patch 
which had already been committed.

If there are no regressions, I will commit.

Aldy
commit a729e47afaedcc474aeaacbca5f59b3f1bae5a8c
Author: Aldy Hernandez <aldyh@redhat.com>
Date:   Fri Nov 15 15:01:55 2013 -0700

    	* gimple.h (enum gf_mask): Change the ordering of GF_OMP_* bits.

Comments

Aldy Hernandez Nov. 16, 2013, 1:20 a.m. UTC | #1
On 11/15/13 15:05, Aldy Hernandez wrote:
>
>> Why all this, and not keep everything but
>> GF_OMP_FOR_KIND_SIMD and GF_OMP_FOR_KIND_DISTRIBUTE
>> as they were, and just use:
>>     GF_OMP_FOR_KIND_DISTIRBUTE = 1 << 0,
>>     GF_OMP_FOR_KIND_SIMD       = 2 << 0,
>>     GF_OMP_FOR_KIND_CILKSIMD   = 3 << 0,
>
> Sounds good.  Testing the following patch against my previous patch
> which had already been committed.
>
> If there are no regressions, I will commit.
>
> Aldy
>

Committed.

Patch
diff mbox

diff --git a/gcc/gimple.h b/gcc/gimple.h
index c7cb9f7..e675b07 100644
--- a/gcc/gimple.h
+++ b/gcc/gimple.h
@@ -102,13 +102,13 @@  enum gf_mask {
     GF_CALL_ALLOCA_FOR_VAR	= 1 << 5,
     GF_CALL_INTERNAL		= 1 << 6,
     GF_OMP_PARALLEL_COMBINED	= 1 << 0,
-    GF_OMP_FOR_KIND_MASK	= 7,
+    GF_OMP_FOR_KIND_MASK	= 3 << 0,
     GF_OMP_FOR_KIND_FOR		= 0 << 0,
+    GF_OMP_FOR_KIND_DISTRIBUTE	= 1 << 0,
     GF_OMP_FOR_KIND_SIMD	= 2 << 0,
     GF_OMP_FOR_KIND_CILKSIMD	= 3 << 0,
-    GF_OMP_FOR_KIND_DISTRIBUTE	= 1 << 2,
-    GF_OMP_FOR_COMBINED		= 1 << 3,
-    GF_OMP_FOR_COMBINED_INTO	= 1 << 4,
+    GF_OMP_FOR_COMBINED		= 1 << 2,
+    GF_OMP_FOR_COMBINED_INTO	= 1 << 3,
     GF_OMP_TARGET_KIND_MASK	= 3 << 0,
     GF_OMP_TARGET_KIND_REGION	= 0 << 0,
     GF_OMP_TARGET_KIND_DATA	= 1 << 0,