diff mbox

[U-Boot,3/5] sf: macronix: Add support for MX66L51235F

Message ID 1384443573-1545-4-git-send-email-sourav.poddar@ti.com
State Superseded
Delegated to: Jagannadha Sutradharudu Teki
Headers show

Commit Message

Poddar, Sourav Nov. 14, 2013, 3:39 p.m. UTC 
From: Jagannadha Sutradharudu Teki <jagannadha.sutradharudu-teki@xilinx.com>

Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
---
 drivers/mtd/spi/sf_probe.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comments

Jagan Teki Dec. 18, 2013, 6:51 p.m. UTC | #1 
On Thu, Nov 14, 2013 at 9:09 PM, Sourav Poddar <sourav.poddar@ti.com> wrote:
> From: Jagannadha Sutradharudu Teki <jagannadha.sutradharudu-teki@xilinx.com>
>
> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
> ---
>  drivers/mtd/spi/sf_probe.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/spi/sf_probe.c b/drivers/mtd/spi/sf_probe.c
> index 5eb8ffe..874ef8c 100644
> --- a/drivers/mtd/spi/sf_probe.c
> +++ b/drivers/mtd/spi/sf_probe.c
> @@ -68,6 +68,7 @@ static const struct spi_flash_params spi_flash_params_table[] = {
>         {"MX25L25635F",    0xc22019, 0x0,       64 * 1024,   512,                    0},
>         {"MX25L51235F",    0xc2201A, 0x0,       64 * 1024,  1024,                    0},
>         {"MX25L12855E",    0xc22618, 0x0,       64 * 1024,   256,                    0},
> +       {"MX66L51235F",    0xc2201a, 0x0,       64 * 1024,  1024,                    0},
What is this - this part is already available is int it?

>  #endif
>  #ifdef CONFIG_SPI_FLASH_SPANSION       /* SPANSION */
>         {"S25FL008A",      0x010213, 0x0,       64 * 1024,    16,                    0},
> @@ -207,6 +208,7 @@ static struct spi_flash *spi_flash_validate_params(struct spi_slave *spi,
>         flash->page_size = (ext_jedec == 0x4d00) ? 512 : 256;
>         flash->sector_size = params->sector_size;
>         flash->size = flash->sector_size * params->nr_sectors;
> +       flash->memory_map = spi->memory_map;
This change is also there - please check.
Poddar, Sourav Dec. 19, 2013, 5:03 a.m. UTC | #2 
On Thursday 19 December 2013 12:21 AM, Jagan Teki wrote:
> On Thu, Nov 14, 2013 at 9:09 PM, Sourav Poddar<sourav.poddar@ti.com>  wrote:
>> From: Jagannadha Sutradharudu Teki<jagannadha.sutradharudu-teki@xilinx.com>
>>
>> Signed-off-by: Jagannadha Sutradharudu Teki<jaganna@xilinx.com>
>> Signed-off-by: Sourav Poddar<sourav.poddar@ti.com>
>> ---
>>   drivers/mtd/spi/sf_probe.c |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/mtd/spi/sf_probe.c b/drivers/mtd/spi/sf_probe.c
>> index 5eb8ffe..874ef8c 100644
>> --- a/drivers/mtd/spi/sf_probe.c
>> +++ b/drivers/mtd/spi/sf_probe.c
>> @@ -68,6 +68,7 @@ static const struct spi_flash_params spi_flash_params_table[] = {
>>          {"MX25L25635F",    0xc22019, 0x0,       64 * 1024,   512,                    0},
>>          {"MX25L51235F",    0xc2201A, 0x0,       64 * 1024,  1024,                    0},
>>          {"MX25L12855E",    0xc22618, 0x0,       64 * 1024,   256,                    0},
>> +       {"MX66L51235F",    0xc2201a, 0x0,       64 * 1024,  1024,                    0},
> What is this - this part is already available is int it?
>
I switched to your master branch and could not see this part added.
>>   #endif
>>   #ifdef CONFIG_SPI_FLASH_SPANSION       /* SPANSION */
>>          {"S25FL008A",      0x010213, 0x0,       64 * 1024,    16,                    0},
>> @@ -207,6 +208,7 @@ static struct spi_flash *spi_flash_validate_params(struct spi_slave *spi,
>>          flash->page_size = (ext_jedec == 0x4d00) ? 512 : 256;
>>          flash->sector_size = params->sector_size;
>>          flash->size = flash->sector_size * params->nr_sectors;
>> +       flash->memory_map = spi->memory_map;
> This change is also there - please check.
>
Yes, this is there.
Jagan Teki Dec. 19, 2013, 5:52 a.m. UTC | #3 
On Thu, Dec 19, 2013 at 10:33 AM, Sourav Poddar <sourav.poddar@ti.com> wrote:
> On Thursday 19 December 2013 12:21 AM, Jagan Teki wrote:
>>
>> On Thu, Nov 14, 2013 at 9:09 PM, Sourav Poddar<sourav.poddar@ti.com>
>> wrote:
>>>
>>> From: Jagannadha Sutradharudu
>>> Teki<jagannadha.sutradharudu-teki@xilinx.com>
>>>
>>> Signed-off-by: Jagannadha Sutradharudu Teki<jaganna@xilinx.com>
>>> Signed-off-by: Sourav Poddar<sourav.poddar@ti.com>
>>> ---
>>>   drivers/mtd/spi/sf_probe.c |    2 ++
>>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/mtd/spi/sf_probe.c b/drivers/mtd/spi/sf_probe.c
>>> index 5eb8ffe..874ef8c 100644
>>> --- a/drivers/mtd/spi/sf_probe.c
>>> +++ b/drivers/mtd/spi/sf_probe.c
>>> @@ -68,6 +68,7 @@ static const struct spi_flash_params
>>> spi_flash_params_table[] = {
>>>          {"MX25L25635F",    0xc22019, 0x0,       64 * 1024,   512,
>>> 0},
>>>          {"MX25L51235F",    0xc2201A, 0x0,       64 * 1024,  1024,
>>> 0},
>>>          {"MX25L12855E",    0xc22618, 0x0,       64 * 1024,   256,
>>> 0},
>>> +       {"MX66L51235F",    0xc2201a, 0x0,       64 * 1024,  1024,
>>> 0},
>>
>> What is this - this part is already available is int it?
>>
> I switched to your master branch and could not see this part added.
http://git.denx.de/?p=u-boot/u-boot-spi.git;a=commitdiff;h=28303f617a01d6663a54062852f67f8150b4c87a
Poddar, Sourav Dec. 19, 2013, 5:54 a.m. UTC | #4 
On Thursday 19 December 2013 11:22 AM, Jagan Teki wrote:
> On Thu, Dec 19, 2013 at 10:33 AM, Sourav Poddar<sourav.poddar@ti.com>  wrote:
>> On Thursday 19 December 2013 12:21 AM, Jagan Teki wrote:
>>> On Thu, Nov 14, 2013 at 9:09 PM, Sourav Poddar<sourav.poddar@ti.com>
>>> wrote:
>>>> From: Jagannadha Sutradharudu
>>>> Teki<jagannadha.sutradharudu-teki@xilinx.com>
>>>>
>>>> Signed-off-by: Jagannadha Sutradharudu Teki<jaganna@xilinx.com>
>>>> Signed-off-by: Sourav Poddar<sourav.poddar@ti.com>
>>>> ---
>>>>    drivers/mtd/spi/sf_probe.c |    2 ++
>>>>    1 files changed, 2 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/drivers/mtd/spi/sf_probe.c b/drivers/mtd/spi/sf_probe.c
>>>> index 5eb8ffe..874ef8c 100644
>>>> --- a/drivers/mtd/spi/sf_probe.c
>>>> +++ b/drivers/mtd/spi/sf_probe.c
>>>> @@ -68,6 +68,7 @@ static const struct spi_flash_params
>>>> spi_flash_params_table[] = {
>>>>           {"MX25L25635F",    0xc22019, 0x0,       64 * 1024,   512,
>>>> 0},
>>>>           {"MX25L51235F",    0xc2201A, 0x0,       64 * 1024,  1024,
>>>> 0},
>>>>           {"MX25L12855E",    0xc22618, 0x0,       64 * 1024,   256,
>>>> 0},
>>>> +       {"MX66L51235F",    0xc2201a, 0x0,       64 * 1024,  1024,
>>>> 0},
>>> What is this - this part is already available is int it?
>>>
>> I switched to your master branch and could not see this part added.
> http://git.denx.de/?p=u-boot/u-boot-spi.git;a=commitdiff;h=28303f617a01d6663a54062852f67f8150b4c87a
>
Looks like its a name change, mine is MX66L..with same property
Jagan Teki Dec. 19, 2013, 5:58 a.m. UTC | #5 
On Thu, Dec 19, 2013 at 11:24 AM, Sourav Poddar <sourav.poddar@ti.com> wrote:
> On Thursday 19 December 2013 11:22 AM, Jagan Teki wrote:
>>
>> On Thu, Dec 19, 2013 at 10:33 AM, Sourav Poddar<sourav.poddar@ti.com>
>> wrote:
>>>
>>> On Thursday 19 December 2013 12:21 AM, Jagan Teki wrote:
>>>>
>>>> On Thu, Nov 14, 2013 at 9:09 PM, Sourav Poddar<sourav.poddar@ti.com>
>>>> wrote:
>>>>>
>>>>> From: Jagannadha Sutradharudu
>>>>> Teki<jagannadha.sutradharudu-teki@xilinx.com>
>>>>>
>>>>> Signed-off-by: Jagannadha Sutradharudu Teki<jaganna@xilinx.com>
>>>>> Signed-off-by: Sourav Poddar<sourav.poddar@ti.com>
>>>>> ---
>>>>>    drivers/mtd/spi/sf_probe.c |    2 ++
>>>>>    1 files changed, 2 insertions(+), 0 deletions(-)
>>>>>
>>>>> diff --git a/drivers/mtd/spi/sf_probe.c b/drivers/mtd/spi/sf_probe.c
>>>>> index 5eb8ffe..874ef8c 100644
>>>>> --- a/drivers/mtd/spi/sf_probe.c
>>>>> +++ b/drivers/mtd/spi/sf_probe.c
>>>>> @@ -68,6 +68,7 @@ static const struct spi_flash_params
>>>>> spi_flash_params_table[] = {
>>>>>           {"MX25L25635F",    0xc22019, 0x0,       64 * 1024,   512,
>>>>> 0},
>>>>>           {"MX25L51235F",    0xc2201A, 0x0,       64 * 1024,  1024,
>>>>> 0},
>>>>>           {"MX25L12855E",    0xc22618, 0x0,       64 * 1024,   256,
>>>>> 0},
>>>>> +       {"MX66L51235F",    0xc2201a, 0x0,       64 * 1024,  1024,
>>>>> 0},
>>>>
>>>> What is this - this part is already available is int it?
>>>>
>>> I switched to your master branch and could not see this part added.
>>
>>
>> http://git.denx.de/?p=u-boot/u-boot-spi.git;a=commitdiff;h=28303f617a01d6663a54062852f67f8150b4c87a
>>
> Looks like its a name change, mine is MX66>>>          while (words--) {
eL..with same property
>

Can you please check - does both were same dev-id's if same, do we
have next id to differentiate (ext_jdec)
diff mbox

Patch

diff --git a/drivers/mtd/spi/sf_probe.c b/drivers/mtd/spi/sf_probe.c
index 5eb8ffe..874ef8c 100644
--- a/drivers/mtd/spi/sf_probe.c
+++ b/drivers/mtd/spi/sf_probe.c
@@ -68,6 +68,7 @@  static const struct spi_flash_params spi_flash_params_table[] = {
 	{"MX25L25635F",	   0xc22019, 0x0,	64 * 1024,   512,	             0},
 	{"MX25L51235F",	   0xc2201A, 0x0,	64 * 1024,  1024,	             0},
 	{"MX25L12855E",	   0xc22618, 0x0,	64 * 1024,   256,	             0},
+	{"MX66L51235F",    0xc2201a, 0x0,	64 * 1024,  1024,                    0},
 #endif
 #ifdef CONFIG_SPI_FLASH_SPANSION	/* SPANSION */
 	{"S25FL008A",	   0x010213, 0x0,	64 * 1024,    16,	             0},
@@ -207,6 +208,7 @@  static struct spi_flash *spi_flash_validate_params(struct spi_slave *spi,
 	flash->page_size = (ext_jedec == 0x4d00) ? 512 : 256;
 	flash->sector_size = params->sector_size;
 	flash->size = flash->sector_size * params->nr_sectors;
+	flash->memory_map = spi->memory_map;
 
 	/* Compute erase sector and command */
 	if (params->flags & SECT_4K) {