diff mbox

fwts: acpi: method: add _UPD and _UPP control method tests (LP: #1251168)

Message ID 1384422005-8541-1-git-send-email-alex.hung@canonical.com
State Accepted
Headers show

Commit Message

Alex Hung Nov. 14, 2013, 9:40 a.m. UTC 
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/acpi/method/method.c | 23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

Comments

Alex Hung Nov. 14, 2013, 9:44 a.m. UTC | #1 
Hi Kengyu,

I just realized that I put an extra "fwts" in subject. Will you be
able to remove it if this patch gets acks?

Cheers,
Alex Hung

On Thu, Nov 14, 2013 at 5:40 PM, Alex Hung <alex.hung@canonical.com> wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/method/method.c | 23 +++++++++++++++++++----
>  1 file changed, 19 insertions(+), 4 deletions(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 1a4f875..a81930e 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -240,8 +240,8 @@
>   * _TZP  11.4.21       Y
>   * _UID  6.1.9         Y
>   * _UPC  9.13          N
> - * _UPD  9.16.1                N
> - * _UPP  9.16.2                N
> + * _UPD  9.16.1                Y
> + * _UPP  9.16.2                Y
>   * _VPO  B.4.6         Y
>   * _WAK  7.3.7                 Y
>   * _Wxx  5.6.4.2.2     n/a
> @@ -3245,6 +3245,21 @@ static int method_test_LID(fwts_framework *fw)
>                 "_LID", NULL, 0, method_test_LID_return, NULL);
>  }
>
> +/*
> + * Section 9.16 User Presence Detection Device
> + */
> +
> +static int method_test_UPD(fwts_framework *fw)
> +{
> +       return method_evaluate_method(fw, METHOD_OPTIONAL,
> +               "_UPD", NULL, 0, method_test_integer_return, NULL);
> +}
> +
> +static int method_test_UPP(fwts_framework *fw)
> +{
> +       return method_evaluate_method(fw, METHOD_OPTIONAL,
> +               "_UPP", NULL, 0, method_test_integer_return, NULL);
> +}
>
>  /*
>   * Section 9.18 Wake Alarm Device
> @@ -5011,8 +5026,8 @@ static fwts_framework_minor_test method_tests[] = {
>         /* { method_test_DSM, "Test _DSM (Device Specific Method)." }, */
>
>         /* Section 9.16 User Presence Detection Device */
> -       /* { method_test_UPD, "Test _UPD (User Presence Detect)." }, */
> -       /* { method_test_UPP, "Test _UPP (User Presence Polling)." }, */
> +       { method_test_UPD, "Test _UPD (User Presence Detect)." },
> +       { method_test_UPP, "Test _UPP (User Presence Polling)." },
>
>         /* Section 9.18 Wake Alarm Device */
>
> --
> 1.8.1.2
>
Colin Ian King Nov. 14, 2013, 10:39 a.m. UTC | #2 
On 14/11/13 09:40, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/method/method.c | 23 +++++++++++++++++++----
>  1 file changed, 19 insertions(+), 4 deletions(-)
> 
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 1a4f875..a81930e 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -240,8 +240,8 @@
>   * _TZP  11.4.21	Y
>   * _UID  6.1.9		Y
>   * _UPC  9.13		N
> - * _UPD  9.16.1		N
> - * _UPP  9.16.2		N
> + * _UPD  9.16.1		Y
> + * _UPP  9.16.2		Y
>   * _VPO  B.4.6		Y
>   * _WAK  7.3.7 		Y
>   * _Wxx  5.6.4.2.2	n/a
> @@ -3245,6 +3245,21 @@ static int method_test_LID(fwts_framework *fw)
>  		"_LID", NULL, 0, method_test_LID_return, NULL);
>  }
>  
> +/*
> + * Section 9.16 User Presence Detection Device
> + */
> +
> +static int method_test_UPD(fwts_framework *fw)
> +{
> +	return method_evaluate_method(fw, METHOD_OPTIONAL,
> +		"_UPD", NULL, 0, method_test_integer_return, NULL);
> +}
> +
> +static int method_test_UPP(fwts_framework *fw)
> +{
> +	return method_evaluate_method(fw, METHOD_OPTIONAL,
> +		"_UPP", NULL, 0, method_test_integer_return, NULL);
> +}
>  
>  /*
>   * Section 9.18 Wake Alarm Device
> @@ -5011,8 +5026,8 @@ static fwts_framework_minor_test method_tests[] = {
>  	/* { method_test_DSM, "Test _DSM (Device Specific Method)." }, */
>  
>  	/* Section 9.16 User Presence Detection Device */
> -	/* { method_test_UPD, "Test _UPD (User Presence Detect)." }, */
> -	/* { method_test_UPP, "Test _UPP (User Presence Polling)." }, */
> +	{ method_test_UPD, "Test _UPD (User Presence Detect)." },
> +	{ method_test_UPP, "Test _UPP (User Presence Polling)." },
>  
>  	/* Section 9.18 Wake Alarm Device */
>  
> 
As noted, "fwts: " should be removed from title of patch.

Acked-by: Colin Ian King <colin.king@canonical.com>
Keng-Yu Lin Nov. 15, 2013, 5:54 a.m. UTC | #3 
On Thu, Nov 14, 2013 at 5:40 PM, Alex Hung <alex.hung@canonical.com> wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/method/method.c | 23 +++++++++++++++++++----
>  1 file changed, 19 insertions(+), 4 deletions(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 1a4f875..a81930e 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -240,8 +240,8 @@
>   * _TZP  11.4.21       Y
>   * _UID  6.1.9         Y
>   * _UPC  9.13          N
> - * _UPD  9.16.1                N
> - * _UPP  9.16.2                N
> + * _UPD  9.16.1                Y
> + * _UPP  9.16.2                Y
>   * _VPO  B.4.6         Y
>   * _WAK  7.3.7                 Y
>   * _Wxx  5.6.4.2.2     n/a
> @@ -3245,6 +3245,21 @@ static int method_test_LID(fwts_framework *fw)
>                 "_LID", NULL, 0, method_test_LID_return, NULL);
>  }
>
> +/*
> + * Section 9.16 User Presence Detection Device
> + */
> +
> +static int method_test_UPD(fwts_framework *fw)
> +{
> +       return method_evaluate_method(fw, METHOD_OPTIONAL,
> +               "_UPD", NULL, 0, method_test_integer_return, NULL);
> +}
> +
> +static int method_test_UPP(fwts_framework *fw)
> +{
> +       return method_evaluate_method(fw, METHOD_OPTIONAL,
> +               "_UPP", NULL, 0, method_test_integer_return, NULL);
> +}
>
>  /*
>   * Section 9.18 Wake Alarm Device
> @@ -5011,8 +5026,8 @@ static fwts_framework_minor_test method_tests[] = {
>         /* { method_test_DSM, "Test _DSM (Device Specific Method)." }, */
>
>         /* Section 9.16 User Presence Detection Device */
> -       /* { method_test_UPD, "Test _UPD (User Presence Detect)." }, */
> -       /* { method_test_UPP, "Test _UPP (User Presence Polling)." }, */
> +       { method_test_UPD, "Test _UPD (User Presence Detect)." },
> +       { method_test_UPP, "Test _UPP (User Presence Polling)." },
>
>         /* Section 9.18 Wake Alarm Device */
>
> --
> 1.8.1.2

Acked-by: Keng-Yu Lin <kengyu@canonical.com>
diff mbox

Patch

diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
index 1a4f875..a81930e 100644
--- a/src/acpi/method/method.c
+++ b/src/acpi/method/method.c
@@ -240,8 +240,8 @@ 
  * _TZP  11.4.21	Y
  * _UID  6.1.9		Y
  * _UPC  9.13		N
- * _UPD  9.16.1		N
- * _UPP  9.16.2		N
+ * _UPD  9.16.1		Y
+ * _UPP  9.16.2		Y
  * _VPO  B.4.6		Y
  * _WAK  7.3.7 		Y
  * _Wxx  5.6.4.2.2	n/a
@@ -3245,6 +3245,21 @@  static int method_test_LID(fwts_framework *fw)
 		"_LID", NULL, 0, method_test_LID_return, NULL);
 }
 
+/*
+ * Section 9.16 User Presence Detection Device
+ */
+
+static int method_test_UPD(fwts_framework *fw)
+{
+	return method_evaluate_method(fw, METHOD_OPTIONAL,
+		"_UPD", NULL, 0, method_test_integer_return, NULL);
+}
+
+static int method_test_UPP(fwts_framework *fw)
+{
+	return method_evaluate_method(fw, METHOD_OPTIONAL,
+		"_UPP", NULL, 0, method_test_integer_return, NULL);
+}
 
 /*
  * Section 9.18 Wake Alarm Device
@@ -5011,8 +5026,8 @@  static fwts_framework_minor_test method_tests[] = {
 	/* { method_test_DSM, "Test _DSM (Device Specific Method)." }, */
 
 	/* Section 9.16 User Presence Detection Device */
-	/* { method_test_UPD, "Test _UPD (User Presence Detect)." }, */
-	/* { method_test_UPP, "Test _UPP (User Presence Polling)." }, */
+	{ method_test_UPD, "Test _UPD (User Presence Detect)." },
+	{ method_test_UPP, "Test _UPP (User Presence Polling)." },
 
 	/* Section 9.18 Wake Alarm Device */