Patchwork [04/12] PCI/portdrv: Remove superfluous name cast

login
register
mail settings
Submitter Geert Uytterhoeven
Date Nov. 12, 2013, 7:07 p.m.
Message ID <1384283245-9419-5-git-send-email-geert@linux-m68k.org>
Download mbox | patch
Permalink /patch/290747/
State Accepted
Headers show

Comments

Geert Uytterhoeven - Nov. 12, 2013, 7:07 p.m.
device_driver.name is "const char *"

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org
---
 drivers/pci/pcie/portdrv_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Bjorn Helgaas - Dec. 7, 2013, 10:35 p.m.
On Tue, Nov 12, 2013 at 08:07:17PM +0100, Geert Uytterhoeven wrote:
> device_driver.name is "const char *"
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: linux-pci@vger.kernel.org

Applied to pci/misc for v3.14, thanks!

> ---
>  drivers/pci/pcie/portdrv_core.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c
> index 31063ac30992..833c18c3eb96 100644
> --- a/drivers/pci/pcie/portdrv_core.c
> +++ b/drivers/pci/pcie/portdrv_core.c
> @@ -553,7 +553,7 @@ int pcie_port_service_register(struct pcie_port_service_driver *new)
>  	if (pcie_ports_disabled)
>  		return -ENODEV;
>  
> -	new->driver.name = (char *)new->name;
> +	new->driver.name = new->name;
>  	new->driver.bus = &pcie_port_bus_type;
>  	new->driver.probe = pcie_port_probe_service;
>  	new->driver.remove = pcie_port_remove_service;
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c
index 31063ac30992..833c18c3eb96 100644
--- a/drivers/pci/pcie/portdrv_core.c
+++ b/drivers/pci/pcie/portdrv_core.c
@@ -553,7 +553,7 @@  int pcie_port_service_register(struct pcie_port_service_driver *new)
 	if (pcie_ports_disabled)
 		return -ENODEV;
 
-	new->driver.name = (char *)new->name;
+	new->driver.name = new->name;
 	new->driver.bus = &pcie_port_bus_type;
 	new->driver.probe = pcie_port_probe_service;
 	new->driver.remove = pcie_port_remove_service;