From patchwork Tue Nov 12 16:45:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 290721 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 866742C00A8 for ; Wed, 13 Nov 2013 03:46:20 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:references :in-reply-to:content-type; q=dns; s=default; b=xWEyI8/Bg9xPrLPvo TFGnn8MNuTWL9fyd6LPQM3nqnfsBLcI2hKloGKF7wv1eeuXfYHAIE7Ar3oL8TgAS 8m20ZicemBMTpdNU4vxymv2EXGL9syz7E5hDTNow2pFDt6RhRnBAFm3/xWuVYz5C 34FlsdcZCp/zfnFda+pw6g0Z+g= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:references :in-reply-to:content-type; s=default; bh=VmjLbefeCxhovyuvK2Gfm/z Bq3Y=; b=WqnEyzKpecr5KeFAmZ8W1ro6oDtmIGi+/AK+dpnE701Bzx/q1F4gBDw lB0DeKgU930Czkz5uCq15b8se31Y9dSP7WCxwPKXKxban0COKZaoYPhY/7wMDMRe jy3THNJOxkNHhYa/1jAGrkAzIW0vKCClSX8VMYeP9HMBzobcI390= Received: (qmail 801 invoked by alias); 12 Nov 2013 16:46:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 792 invoked by uid 89); 12 Nov 2013 16:46:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.5 required=5.0 tests=AWL, BAYES_50, RDNS_NONE, SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Nov 2013 16:46:07 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rACGjxZk024298 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 12 Nov 2013 11:45:59 -0500 Received: from reynosa.quesejoda.com (vpn-56-111.rdu2.redhat.com [10.10.56.111]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rACGjv0w026971; Tue, 12 Nov 2013 11:45:57 -0500 Message-ID: <52825B44.5080809@redhat.com> Date: Tue, 12 Nov 2013 09:45:56 -0700 From: Aldy Hernandez User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Jakub Jelinek , Richard Henderson , Richard Biener , Jan Hubicka , gcc-patches , "Iyer, Balaji V" Subject: Re: RFC: simd enabled functions (omp declare simd / elementals) References: <52731A4D.6020402@redhat.com> <20131107160913.GE3572@virgil.suse> <527D23FB.8000206@redhat.com> <20131111175739.GB10643@virgil.suse> In-Reply-To: <20131111175739.GB10643@virgil.suse> >> +/* Operation to be performed for the parameter in ipa_parm_adjustment >> + below. */ >> +enum ipa_parm_op { >> + IPA_PARM_OP_NONE, >> + >> + /* This describes a brand new parameter. >> + >> + For new parameters, base_index must be >= the number of >> + DECL_ARGUMENTS in the function. That is, new arguments will be >> + the last arguments in the adjusted function. > > ...where this requirement comes from. I would think that base_index > would be completely ignored for the new parameters, is it not? Well, whadayaknow... base_index is indeed ignored, and a cursory look at ipa_modify_formal_parameters() suggests that you may be able to insert arguments out of order (untested). Jakub, you may be in luck :). Committing the attached fix to the branch. Thanks again. commit cc9c895aebe4ba1c017720fe5a43599b53696236 Author: Aldy Hernandez Date: Tue Nov 12 09:42:30 2013 -0700 * ipa-prop.h (enum ipa_parm_op): Adjust comment to IPA_PARM_OP_NEW entry. diff --git a/gcc/ipa-prop.h b/gcc/ipa-prop.h index 0621a13..a2d8797 100644 --- a/gcc/ipa-prop.h +++ b/gcc/ipa-prop.h @@ -616,11 +616,7 @@ enum ipa_parm_op { /* This describes a brand new parameter. - For new parameters, base_index must be >= the number of - DECL_ARGUMENTS in the function. That is, new arguments will be - the last arguments in the adjusted function. - - Also, `type' should be set to the new type, `arg_prefix' + The field `type' should be set to the new type, `arg_prefix' should be set to the string prefix for the new DECL_NAME, and `new_decl' will ultimately hold the newly created argument. */ IPA_PARM_OP_NEW,