Patchwork [5/4] sparc32: Fix makefile not generating required files

login
register
mail settings
Submitter Julian Calaby
Date June 23, 2009, 11:45 a.m.
Message ID <4A40C06A.6000600@gmail.com>
Download mbox | patch
Permalink /patch/29057/
State Accepted
Delegated to: David Miller
Headers show

Comments

Julian Calaby - June 23, 2009, 11:45 a.m.
The tftpboot build was failing with missing file errors.

It turns out that $(obj)/image wasn't being generated which was causing the a.out conversion to be skipped and hence piggyback to be called with nonexistent files.

Signed-off-by: Julian Calaby <julian.calaby@gmail.com>
---
 arch/sparc/boot/Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - June 26, 2009, 2:57 a.m.
Julian I applied all of your patches, thanks a lot!
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Julian Calaby - June 26, 2009, 3:24 a.m.
On Fri, Jun 26, 2009 at 12:57, David Miller<davem@davemloft.net> wrote:
>
> Julian I applied all of your patches, thanks a lot!

Thanks!

Patch

diff --git a/arch/sparc/boot/Makefile b/arch/sparc/boot/Makefile
index 500a2f8..1ff0fd9 100644
--- a/arch/sparc/boot/Makefile
+++ b/arch/sparc/boot/Makefile
@@ -58,7 +58,7 @@  $(obj)/image: $(obj)/btfix.o FORCE
 $(obj)/zImage: $(obj)/image
 	$(call if_changed,strip)
 
-$(obj)/tftpboot.img: $(obj)/piggyback_32 System.map $(ROOT_IMG) FORCE
+$(obj)/tftpboot.img: $(obj)/image $(obj)/piggyback_32 System.map $(ROOT_IMG) FORCE
 	$(call if_changed,elftoaout)
 	$(call if_changed,piggy)
 
@@ -79,7 +79,7 @@  $(obj)/image: vmlinux FORCE
 	$(call if_changed,strip)
 	@echo '  kernel: $@ is ready'
 
-$(obj)/tftpboot.img: vmlinux $(obj)/piggyback_64 System.map $(ROOT_IMG) FORCE
+$(obj)/tftpboot.img: $(obj)/image $(obj)/piggyback_64 System.map $(ROOT_IMG) FORCE
 	$(call if_changed,elftoaout)
 	$(call if_changed,piggy)
 	@echo '  kernel: $@ is ready'