Patchwork iozone: depends on threads

login
register
mail settings
Submitter Simon Dawson
Date Nov. 11, 2013, 10:20 a.m.
Message ID <1384165234-18705-1-git-send-email-spdawson@gmail.com>
Download mbox | patch
Permalink /patch/290224/
State Changes Requested
Headers show

Comments

Simon Dawson - Nov. 11, 2013, 10:20 a.m.
From: Simon Dawson <spdawson@gmail.com>

Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
 package/iozone/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)
Thomas Petazzoni - Nov. 11, 2013, 10:44 a.m.
Dear spdawson@gmail.com,

On Mon, 11 Nov 2013 10:20:34 +0000, spdawson@gmail.com wrote:
> From: Simon Dawson <spdawson@gmail.com>
> 
> Signed-off-by: Simon Dawson <spdawson@gmail.com>
> ---
>  package/iozone/Config.in | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/package/iozone/Config.in b/package/iozone/Config.in
> index 33e12ca..6638b7c 100644
> --- a/package/iozone/Config.in
> +++ b/package/iozone/Config.in
> @@ -2,8 +2,14 @@ config BR2_PACKAGE_IOZONE
>  	bool "iozone"
>  	depends on BR2_USE_MMU # fork()
>  	depends on !BR2_UCLIBC_VERSION_0_9_31 # no pthread_setaffinity_np
> +	depends on BR2_PTHREADS_NATIVE || BR2_TOOLCHAIN_BUILDROOT_EGLIBC || BR2_TOOLCHAIN_BUILDROOT_GLIBC
>  	help
>  	  IOzone is a filesystem benchmark tool.
>  	  The benchmark generates and measures a variety of file operations
>  
>  	  http://www.iozone.org/
> +
> +comment "iozone needs a toolchain w/ threads"
> +	depends on BR2_USE_MMU
> +	depends on !BR2_UCLIBC_VERSION_0_9_31
> +	depends on !(BR2_PTHREADS_NATIVE || BR2_TOOLCHAIN_BUILDROOT_EGLIBC || BR2_TOOLCHAIN_BUILDROOT_GLIBC)

No, this will make iozone invisible when building with external
toolchains. See my other reply to the e-mail suggesting to add
BR2_THREADS_NATIVE as a dependency.

Best regards,

Thomas
Simon Dawson - Nov. 11, 2013, 10:50 a.m.
Hi Thomas,

On 11 November 2013 10:44, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> No, this will make iozone invisible when building with external
> toolchains. See my other reply to the e-mail suggesting to add
> BR2_THREADS_NATIVE as a dependency.

Yes, I saw that, but too late. This looks to be more involved than I
had assumed it to be...

Simon.

Patch

diff --git a/package/iozone/Config.in b/package/iozone/Config.in
index 33e12ca..6638b7c 100644
--- a/package/iozone/Config.in
+++ b/package/iozone/Config.in
@@ -2,8 +2,14 @@  config BR2_PACKAGE_IOZONE
 	bool "iozone"
 	depends on BR2_USE_MMU # fork()
 	depends on !BR2_UCLIBC_VERSION_0_9_31 # no pthread_setaffinity_np
+	depends on BR2_PTHREADS_NATIVE || BR2_TOOLCHAIN_BUILDROOT_EGLIBC || BR2_TOOLCHAIN_BUILDROOT_GLIBC
 	help
 	  IOzone is a filesystem benchmark tool.
 	  The benchmark generates and measures a variety of file operations
 
 	  http://www.iozone.org/
+
+comment "iozone needs a toolchain w/ threads"
+	depends on BR2_USE_MMU
+	depends on !BR2_UCLIBC_VERSION_0_9_31
+	depends on !(BR2_PTHREADS_NATIVE || BR2_TOOLCHAIN_BUILDROOT_EGLIBC || BR2_TOOLCHAIN_BUILDROOT_GLIBC)