From patchwork Mon Jun 22 22:53:07 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: ext4: remove redundant test on unsigned Date: Mon, 22 Jun 2009 12:53:07 -0000 From: roel kluin X-Patchwork-Id: 29018 Message-Id: <4A400B53.2080903@gmail.com> To: tytso@mit.edu Cc: linux-ext4@vger.kernel.org, Andrew Morton unsigned i_block cannot be less than 0. Signed-off-by: Roel Kluin --- Maybe a test `if (i_block > MAX)' but what should MAX be? -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 7c17ae2..3cd567d 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -343,9 +343,7 @@ static int ext4_block_to_path(struct inode *inode, int n = 0; int final = 0; - if (i_block < 0) { - ext4_warning(inode->i_sb, "ext4_block_to_path", "block < 0"); - } else if (i_block < direct_blocks) { + if (i_block < direct_blocks) { offsets[n++] = i_block; final = direct_blocks; } else if ((i_block -= direct_blocks) < indirect_blocks) {