Patchwork ext4: remove redundant test on unsigned

login
register
mail settings
Submitter roel kluin
Date June 22, 2009, 10:53 p.m.
Message ID <4A400B53.2080903@gmail.com>
Download mbox | patch
Permalink /patch/29018/
State New
Headers show

Comments

roel kluin - June 22, 2009, 10:53 p.m.
unsigned i_block cannot be less than 0.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Maybe a test `if (i_block > MAX)' but what should MAX be?

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Theodore Ts'o - Aug. 11, 2009, 2:48 a.m.
On Tue, Jun 23, 2009 at 12:53:07AM +0200, Roel Kluin wrote:
> unsigned i_block cannot be less than 0.
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>

Applied, my apologies for the delay.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 7c17ae2..3cd567d 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -343,9 +343,7 @@  static int ext4_block_to_path(struct inode *inode,
 	int n = 0;
 	int final = 0;
 
-	if (i_block < 0) {
-		ext4_warning(inode->i_sb, "ext4_block_to_path", "block < 0");
-	} else if (i_block < direct_blocks) {
+	if (i_block < direct_blocks) {
 		offsets[n++] = i_block;
 		final = direct_blocks;
 	} else if ((i_block -= direct_blocks) < indirect_blocks) {