diff mbox

[3/3] acpi: method: add _PMM control method test (LP: #1249941)

Message ID 1384146340-2695-3-git-send-email-alex.hung@canonical.com
State Accepted
Headers show

Commit Message

Alex Hung Nov. 11, 2013, 5:05 a.m. UTC
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/acpi/method/method.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

Comments

Colin Ian King Nov. 11, 2013, 9:16 a.m. UTC | #1
On 11/11/13 05:05, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/method/method.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index a8c25bc..038cbbb 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -147,7 +147,7 @@
>   * _PLD  6.1.8		Y
>   * _PMC  10.4.1		N
>   * _PMD  10.4.8		N
> - * _PMM  10.4.3		N
> + * _PMM  10.4.3		Y
>   * _PPC  8.4.4.3	Y
>   * _PPE  8.4.6		Y
>   * _PR   5.3.1		n/a
> @@ -4018,6 +4018,12 @@ static int method_test_GAI(fwts_framework *fw)
>  		"_GAI", NULL, 0, method_test_integer_return, NULL);
>  }
>  
> +static int method_test_PMM(fwts_framework *fw)
> +{
> +	return method_evaluate_method(fw, METHOD_OPTIONAL,
> +		"_PMM", NULL, 0, method_test_integer_return, NULL);
> +}
> +
>  /*
>   * Section 11.3 Fan Devices
>   */
> @@ -5031,7 +5037,7 @@ static fwts_framework_minor_test method_tests[] = {
>  	/* { method_test_PAI, "Check _PAI (Power Averaging Interval)." }, */
>  	/* { method_test_PMC, "Check _PMC (Power Meter Capabilities)." }, */
>  	/* { method_test_PMD, "Check _PMD (Power Meter Devices)." }, */
> -	/* { method_test_PMM, "Check _PMM (Power Meter Measurement)." }, */
> +	 { method_test_PMM, "Check _PMM (Power Meter Measurement)." },
>  	/* { method_test_PTP, "Check _PTP (Power Trip Points)." }, */
>  	/* { method_test_SHL, "Check _SHL (Set Hardware Limit)." }, */
>  
> 
Acked-by: Colin Ian King <colin.king@canonical.com>
Keng-Yu Lin Nov. 12, 2013, 7:29 a.m. UTC | #2
On Mon, Nov 11, 2013 at 1:05 PM, Alex Hung <alex.hung@canonical.com> wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/method/method.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index a8c25bc..038cbbb 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -147,7 +147,7 @@
>   * _PLD  6.1.8         Y
>   * _PMC  10.4.1                N
>   * _PMD  10.4.8                N
> - * _PMM  10.4.3                N
> + * _PMM  10.4.3                Y
>   * _PPC  8.4.4.3       Y
>   * _PPE  8.4.6         Y
>   * _PR   5.3.1         n/a
> @@ -4018,6 +4018,12 @@ static int method_test_GAI(fwts_framework *fw)
>                 "_GAI", NULL, 0, method_test_integer_return, NULL);
>  }
>
> +static int method_test_PMM(fwts_framework *fw)
> +{
> +       return method_evaluate_method(fw, METHOD_OPTIONAL,
> +               "_PMM", NULL, 0, method_test_integer_return, NULL);
> +}
> +
>  /*
>   * Section 11.3 Fan Devices
>   */
> @@ -5031,7 +5037,7 @@ static fwts_framework_minor_test method_tests[] = {
>         /* { method_test_PAI, "Check _PAI (Power Averaging Interval)." }, */
>         /* { method_test_PMC, "Check _PMC (Power Meter Capabilities)." }, */
>         /* { method_test_PMD, "Check _PMD (Power Meter Devices)." }, */
> -       /* { method_test_PMM, "Check _PMM (Power Meter Measurement)." }, */
> +        { method_test_PMM, "Check _PMM (Power Meter Measurement)." },
>         /* { method_test_PTP, "Check _PTP (Power Trip Points)." }, */
>         /* { method_test_SHL, "Check _SHL (Set Hardware Limit)." }, */
>
> --
> 1.8.3.2
>

Acked-by: Keng-Yu Lin <kengyu@canonical.com>
diff mbox

Patch

diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
index a8c25bc..038cbbb 100644
--- a/src/acpi/method/method.c
+++ b/src/acpi/method/method.c
@@ -147,7 +147,7 @@ 
  * _PLD  6.1.8		Y
  * _PMC  10.4.1		N
  * _PMD  10.4.8		N
- * _PMM  10.4.3		N
+ * _PMM  10.4.3		Y
  * _PPC  8.4.4.3	Y
  * _PPE  8.4.6		Y
  * _PR   5.3.1		n/a
@@ -4018,6 +4018,12 @@  static int method_test_GAI(fwts_framework *fw)
 		"_GAI", NULL, 0, method_test_integer_return, NULL);
 }
 
+static int method_test_PMM(fwts_framework *fw)
+{
+	return method_evaluate_method(fw, METHOD_OPTIONAL,
+		"_PMM", NULL, 0, method_test_integer_return, NULL);
+}
+
 /*
  * Section 11.3 Fan Devices
  */
@@ -5031,7 +5037,7 @@  static fwts_framework_minor_test method_tests[] = {
 	/* { method_test_PAI, "Check _PAI (Power Averaging Interval)." }, */
 	/* { method_test_PMC, "Check _PMC (Power Meter Capabilities)." }, */
 	/* { method_test_PMD, "Check _PMD (Power Meter Devices)." }, */
-	/* { method_test_PMM, "Check _PMM (Power Meter Measurement)." }, */
+	 { method_test_PMM, "Check _PMM (Power Meter Measurement)." },
 	/* { method_test_PTP, "Check _PTP (Power Trip Points)." }, */
 	/* { method_test_SHL, "Check _SHL (Set Hardware Limit)." }, */