diff mbox

[2/3] acpi: method: add _MSG control method test (LP: #1249939)

Message ID 1384146340-2695-2-git-send-email-alex.hung@canonical.com
State Accepted
Headers show

Commit Message

Alex Hung Nov. 11, 2013, 5:05 a.m. UTC
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/acpi/method/method.c | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

Comments

Colin Ian King Nov. 11, 2013, 9:15 a.m. UTC | #1
On 11/11/13 05:05, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/method/method.c | 19 +++++++++++++++++--
>  1 file changed, 17 insertions(+), 2 deletions(-)
> 
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 14a908a..a8c25bc 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -128,7 +128,7 @@
>   * _MAT  6.2.9		N
>   * _MBM  9.12.2.1	N
>   * _MLS  6.1.7		N
> - * _MSG  9.1.2		N
> + * _MSG  9.1.2		Y
>   * _MSM  9.12.2.2	N
>   * _NTT  11.4.7		Y
>   * _OFF  7.1.2		Y
> @@ -3184,6 +3184,21 @@ static int method_test_TSS(fwts_framework *fw)
>  
>  
>  /*
> + * Section 9.1 System Indicators
> + */
> +
> +static int method_test_MSG(fwts_framework *fw)
> +{
> +	ACPI_OBJECT arg[1];
> +
> +	arg[0].Type = ACPI_TYPE_INTEGER;
> +	arg[0].Integer.Value = 0;
> +
> +	return method_evaluate_method(fw, METHOD_OPTIONAL,
> +		"_MSG", arg, 1, method_test_NULL_return, NULL);
> +}
> +
> +/*
>   * Section 9.2 Ambient Light Sensor Device
>   */
>  method_test_integer(_ALC, METHOD_OPTIONAL)
> @@ -4930,7 +4945,7 @@ static fwts_framework_minor_test method_tests[] = {
>  
>  	/* Section 9.1 System Indicators */
>  	/* { method_test_CWS, "Check _CWS (Clear Wake Status)." }, */
> -	/* { method_test_MSG, "Check _MSG (Message)." }, */
> +	{ method_test_MSG, "Check _MSG (Message)." },
>  	/* { method_test_PUR, "Check _PUR (Processor Utilization Request)." }, */
>  	/* { method_test_SST, "Check _SST (System Status)." }, */
>  
> 
Acked-by: Colin Ian King <colin.king@canonical.com>
Keng-Yu Lin Nov. 12, 2013, 7:29 a.m. UTC | #2
On Mon, Nov 11, 2013 at 1:05 PM, Alex Hung <alex.hung@canonical.com> wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/method/method.c | 19 +++++++++++++++++--
>  1 file changed, 17 insertions(+), 2 deletions(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 14a908a..a8c25bc 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -128,7 +128,7 @@
>   * _MAT  6.2.9         N
>   * _MBM  9.12.2.1      N
>   * _MLS  6.1.7         N
> - * _MSG  9.1.2         N
> + * _MSG  9.1.2         Y
>   * _MSM  9.12.2.2      N
>   * _NTT  11.4.7                Y
>   * _OFF  7.1.2         Y
> @@ -3184,6 +3184,21 @@ static int method_test_TSS(fwts_framework *fw)
>
>
>  /*
> + * Section 9.1 System Indicators
> + */
> +
> +static int method_test_MSG(fwts_framework *fw)
> +{
> +       ACPI_OBJECT arg[1];
> +
> +       arg[0].Type = ACPI_TYPE_INTEGER;
> +       arg[0].Integer.Value = 0;
> +
> +       return method_evaluate_method(fw, METHOD_OPTIONAL,
> +               "_MSG", arg, 1, method_test_NULL_return, NULL);
> +}
> +
> +/*
>   * Section 9.2 Ambient Light Sensor Device
>   */
>  method_test_integer(_ALC, METHOD_OPTIONAL)
> @@ -4930,7 +4945,7 @@ static fwts_framework_minor_test method_tests[] = {
>
>         /* Section 9.1 System Indicators */
>         /* { method_test_CWS, "Check _CWS (Clear Wake Status)." }, */
> -       /* { method_test_MSG, "Check _MSG (Message)." }, */
> +       { method_test_MSG, "Check _MSG (Message)." },
>         /* { method_test_PUR, "Check _PUR (Processor Utilization Request)." }, */
>         /* { method_test_SST, "Check _SST (System Status)." }, */
>
> --
> 1.8.3.2
>

Acked-by: Keng-Yu Lin <kengyu@canonical.com>
diff mbox

Patch

diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
index 14a908a..a8c25bc 100644
--- a/src/acpi/method/method.c
+++ b/src/acpi/method/method.c
@@ -128,7 +128,7 @@ 
  * _MAT  6.2.9		N
  * _MBM  9.12.2.1	N
  * _MLS  6.1.7		N
- * _MSG  9.1.2		N
+ * _MSG  9.1.2		Y
  * _MSM  9.12.2.2	N
  * _NTT  11.4.7		Y
  * _OFF  7.1.2		Y
@@ -3184,6 +3184,21 @@  static int method_test_TSS(fwts_framework *fw)
 
 
 /*
+ * Section 9.1 System Indicators
+ */
+
+static int method_test_MSG(fwts_framework *fw)
+{
+	ACPI_OBJECT arg[1];
+
+	arg[0].Type = ACPI_TYPE_INTEGER;
+	arg[0].Integer.Value = 0;
+
+	return method_evaluate_method(fw, METHOD_OPTIONAL,
+		"_MSG", arg, 1, method_test_NULL_return, NULL);
+}
+
+/*
  * Section 9.2 Ambient Light Sensor Device
  */
 method_test_integer(_ALC, METHOD_OPTIONAL)
@@ -4930,7 +4945,7 @@  static fwts_framework_minor_test method_tests[] = {
 
 	/* Section 9.1 System Indicators */
 	/* { method_test_CWS, "Check _CWS (Clear Wake Status)." }, */
-	/* { method_test_MSG, "Check _MSG (Message)." }, */
+	{ method_test_MSG, "Check _MSG (Message)." },
 	/* { method_test_PUR, "Check _PUR (Processor Utilization Request)." }, */
 	/* { method_test_SST, "Check _SST (System Status)." }, */