| Message ID | 1384141673-8864-1-git-send-email-yamada.m@jp.panasonic.com |
|---|---|
| State | Rejected |
| Delegated to: | Simon Glass |
| Headers | show |
On Mon, Nov 11, 2013 at 12:47:53PM +0900, Masahiro Yamada wrote: > Commit fea25720 renamed arch/i386 to arch/x86. > But it missed to modify examples/standalone/Makefile. > > This commit revives examples/standalone/82559_eeprom. > > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> > Cc: Simon Glass <sjg@chromium.org> > > --- > Hello, Simon. > > I think examples/standalone/82559_eeprom should have been > originally implemented for i386(x86) architecture > but it has never compiled more than two years. > (And I am probably the first one to notice this.) > > I chosed to add it again rather than delete it in this patch. > If you do not need it any more, I am glad to re-post v2 > to delete it. Note that now that we build this I see: i586-angstrom-linux-ld: warning: cannot find entry symbol 82559_eeprom; defaulting to 0000000000040000 So a new warning on coreboot-x86. I'm giving this patch to Simon in patchwork and he can either follow-up with a patch fixing the warning or nak and delete the example.
Hello Tom, Simon. > On Mon, Nov 11, 2013 at 12:47:53PM +0900, Masahiro Yamada wrote: > > > Commit fea25720 renamed arch/i386 to arch/x86. > > But it missed to modify examples/standalone/Makefile. > > > > This commit revives examples/standalone/82559_eeprom. > > > > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> > > Cc: Simon Glass <sjg@chromium.org> > > > > --- > > Hello, Simon. > > > > I think examples/standalone/82559_eeprom should have been > > originally implemented for i386(x86) architecture > > but it has never compiled more than two years. > > (And I am probably the first one to notice this.) > > > > I chosed to add it again rather than delete it in this patch. > > If you do not need it any more, I am glad to re-post v2 > > to delete it. > > Note that now that we build this I see: > i586-angstrom-linux-ld: warning: cannot find entry symbol 82559_eeprom; > defaulting to 0000000000040000 > > So a new warning on coreboot-x86. I'm giving this patch to Simon in > patchwork and he can either follow-up with a patch fixing the warning or > nak and delete the example. > > -- > Tom Simon. I am not sure if examples/standalone/8259_eeprom.c is necessary or not because I could not get any comments from you about this patch. But it's OK for now. Anyway I want to go forward. So, I posted a new patch to replace this patch: http://patchwork.ozlabs.org/patch/294742/ In that patch, I commened out 82559_eeprom in Makefile. Please note a TODO item in a comment block in examples/standalone/Makefile: # TODO: # - Fix the warning of 82559_eeprom.c and uncomment the following # or # - Delete 82559_eeprom.c and the following line #ELF-$(CONFIG_X86) += 82559_eeprom You don't need to hurry to do this. But I'd appreciate if you could do this when you find time. Tom. I do not need this patch any more. Could you change the status of this patch to Superseded? Best Regards Masahiro Yamada
Hi Guys, On Thu, Nov 28, 2013 at 2:44 PM, Masahiro Yamada <yamada.m@jp.panasonic.com>wrote: > Hello Tom, Simon. > > > > > On Mon, Nov 11, 2013 at 12:47:53PM +0900, Masahiro Yamada wrote: > > > > > Commit fea25720 renamed arch/i386 to arch/x86. > > > But it missed to modify examples/standalone/Makefile. > Oops - my bad :) > > > > > > This commit revives examples/standalone/82559_eeprom. > > > > > > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> > > > Cc: Simon Glass <sjg@chromium.org> > > > > > > --- > > > Hello, Simon. > > > > > > I think examples/standalone/82559_eeprom should have been > > > originally implemented for i386(x86) architecture > > > but it has never compiled more than two years. > > > (And I am probably the first one to notice this.) > > > > > > I chosed to add it again rather than delete it in this patch. > > > If you do not need it any more, I am glad to re-post v2 > > > to delete it. > > > > Note that now that we build this I see: > > i586-angstrom-linux-ld: warning: cannot find entry symbol 82559_eeprom; > > defaulting to 0000000000040000 > > > > So a new warning on coreboot-x86. I'm giving this patch to Simon in > > patchwork and he can either follow-up with a patch fixing the warning or > > nak and delete the example. > <http://lists.denx.de/mailman/listinfo/u-boot> > To be honest, I don't think this will ever be used. 'Hello World' provides a perfect example of a standalone application on the x86 as it stands already. The 82559 is the EEPROM for the Intel Fast Ethernet controller, and as such, I think any interface to it should be done via a proper driver and not by a standalone application. Besides, I really doubt that there are any systems using an 82559 and U-Boot in the wild, and probably never will be. I vote for deletion Regards, Graeme
Hi, On 27 November 2013 21:07, Graeme Russ <graeme.russ@gmail.com> wrote: > Hi Guys, > > > On Thu, Nov 28, 2013 at 2:44 PM, Masahiro Yamada < > yamada.m@jp.panasonic.com> wrote: > >> Hello Tom, Simon. >> >> >> >> > On Mon, Nov 11, 2013 at 12:47:53PM +0900, Masahiro Yamada wrote: >> > >> > > Commit fea25720 renamed arch/i386 to arch/x86. >> > > But it missed to modify examples/standalone/Makefile. >> > > Oops - my bad :) > > >> > > >> > > This commit revives examples/standalone/82559_eeprom. >> > > >> > > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> >> > > Cc: Simon Glass <sjg@chromium.org> >> > > >> > > --- >> > > Hello, Simon. >> > > >> > > I think examples/standalone/82559_eeprom should have been >> > > originally implemented for i386(x86) architecture >> > > but it has never compiled more than two years. >> > > (And I am probably the first one to notice this.) >> > > >> > > I chosed to add it again rather than delete it in this patch. >> > > If you do not need it any more, I am glad to re-post v2 >> > > to delete it. >> > >> > Note that now that we build this I see: >> > i586-angstrom-linux-ld: warning: cannot find entry symbol 82559_eeprom; >> > defaulting to 0000000000040000 >> > >> > So a new warning on coreboot-x86. I'm giving this patch to Simon in >> > patchwork and he can either follow-up with a patch fixing the warning or >> > nak and delete the example. >> <http://lists.denx.de/mailman/listinfo/u-boot> >> > > To be honest, I don't think this will ever be used. 'Hello World' provides > a perfect example of a standalone application on the x86 as it stands > already. > > The 82559 is the EEPROM for the Intel Fast Ethernet controller, and as > such, I think any interface to it should be done via a proper driver and > not by a standalone application. Besides, I really doubt that there are any > systems using an 82559 and U-Boot in the wild, and probably never will be. > > I vote for deletion > Thanks Graeme. Fine with me. Masahiro will do you a patch or should I? Regards, Simon
Hello. > > I vote for deletion > > > > Thanks Graeme. Fine with me. Masahiro will do you a patch or should I? Thank you, Graeme, Simon. I will send a patch lator to avoid a conflict with my other patches. Best Regards Masahiro Yamada
Dear Graeme, In message <CALButCLwhOsYwDYCVnRZU_=2ODEah_40grSEr59coYAc=RUJ7w@mail.gmail.com> you wrote: > > The 82559 is the EEPROM for the Intel Fast Ethernet controller, and as > such, I think any interface to it should be done via a proper driver and > not by a standalone application. Besides, I really doubt that there are any > systems using an 82559 and U-Boot in the wild, and probably never will be. Actually a big telecom company used this in one of their products, and I assume it was quite high volume - but then, this was about a decade ago, or so. Given the typical lifetime of such products there are probably still a number of them around, but you are right: this code is of nostalgic value at best. Best regards, Wolfgang Denk
Hi. We no longer need this patch on Patchwork. Please reject it. Best Regards Masahiro Yamada
diff --git a/examples/standalone/Makefile b/examples/standalone/Makefile index 9346921..237b737 100644 --- a/examples/standalone/Makefile +++ b/examples/standalone/Makefile @@ -14,7 +14,7 @@ ELF-y := hello_world ELF-$(CONFIG_SMC91111) += smc91111_eeprom ELF-$(CONFIG_SMC911X) += smc911x_eeprom ELF-$(CONFIG_SPI_FLASH_ATMEL) += atmel_df_pow2 -ELF-i386 += 82559_eeprom +ELF-x86 += 82559_eeprom ELF-mpc5xxx += interrupt ELF-mpc8xx += test_burst timer ELF-mpc8260 += mem_to_mem_idma2intr
Commit fea25720 renamed arch/i386 to arch/x86. But it missed to modify examples/standalone/Makefile. This commit revives examples/standalone/82559_eeprom. Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> Cc: Simon Glass <sjg@chromium.org> --- Hello, Simon. I think examples/standalone/82559_eeprom should have been originally implemented for i386(x86) architecture but it has never compiled more than two years. (And I am probably the first one to notice this.) I chosed to add it again rather than delete it in this patch. If you do not need it any more, I am glad to re-post v2 to delete it. examples/standalone/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)