Message ID | 1384102985-24923-1-git-send-email-thierry.bultel@wanadoo.fr |
---|---|
State | Superseded |
Headers | show |
diff --git a/Makefile b/Makefile index 1496bd7..7f835c0 100644 --- a/Makefile +++ b/Makefile @@ -548,7 +548,7 @@ target-generatelocales: host-localedef I18NPATH=$(STAGING_DIR)/usr/share/i18n:/usr/share/i18n \ $(HOST_DIR)/usr/bin/localedef \ --prefix=$(TARGET_DIR) \ - --`echo $(BR2_ENDIAN) | tr [A-Z] [a-z]`-endian \ + --`echo $(BR2_ENDIAN) | tr '[A-Z]' '[a-z]'`-endian \ -i $${inputfile} -f $${charmap} \ $${locale} ; \ done
When calling 'tr' without quoting braces, bash can make really weird things if there are existing 'single-letter-named' directories eg: thierry@thierry-desktop:~$ echo AAA | tr [A-Z] [a-z] aaa thierry@thierry-desktop:~$ mkdir m thierry@thierry-desktop:~$ echo AAA | tr [A-Z] [a-z] AAA The (quick) analysis is that the callee (tr) argvs then contain 'm' thus the translation does not work Using quotes works around it tbultel@laois:~/test$ echo AAA | tr '[A-Z]' '[a-z]' aaa Signed-off-by: Thierry Bultel <thierry.bultel@wanadoo.fr> --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)