Patchwork [5/4] sparc32: Fix makefile not generating required files

login
register
mail settings
Submitter Julian Calaby
Date June 22, 2009, 11:57 a.m.
Message ID <4A3F71BD.5060502@gmail.com>
Download mbox | patch
Permalink /patch/28992/
State Superseded
Delegated to: David Miller
Headers show

Comments

Julian Calaby - June 22, 2009, 11:57 a.m.
The tftpboot build was failing with missing file errors.

It turns out that $(obj)/image wasn't being generated which was causing the a.out conversion to be skipped and hence piggyback to be called with nonexistent files.

Signed-off-by: Julian Calaby <julian.calaby@gmail.com>

---

 arch/sparc/boot/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Julian Calaby - June 22, 2009, 11:16 p.m.
On Mon, Jun 22, 2009 at 21:57, Julian Calaby<julian.calaby@gmail.com> wrote:
> The tftpboot build was failing with missing file errors.
>
> It turns out that $(obj)/image wasn't being generated which was causing the a.out conversion to be skipped and hence piggyback to be called with nonexistent files.

Sparc64's rule also needs this fix.

New patch tonight.

Thanks,
David Miller - June 23, 2009, 11:27 a.m.
From: Julian Calaby <julian.calaby@gmail.com>
Date: Tue, 23 Jun 2009 09:16:04 +1000

> On Mon, Jun 22, 2009 at 21:57, Julian Calaby<julian.calaby@gmail.com> wrote:
>> The tftpboot build was failing with missing file errors.
>>
>> It turns out that $(obj)/image wasn't being generated which was causing the a.out conversion to be skipped and hence piggyback to be called with nonexistent files.
> 
> Sparc64's rule also needs this fix.
> 
> New patch tonight.

Did you send this out and I just missed it somehow?
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Julian Calaby - June 23, 2009, 11:29 a.m.
On Tue, Jun 23, 2009 at 21:27, David Miller<davem@davemloft.net> wrote:
> From: Julian Calaby <julian.calaby@gmail.com>
> Date: Tue, 23 Jun 2009 09:16:04 +1000
>
>> On Mon, Jun 22, 2009 at 21:57, Julian Calaby<julian.calaby@gmail.com> wrote:
>>> The tftpboot build was failing with missing file errors.
>>>
>>> It turns out that $(obj)/image wasn't being generated which was causing the a.out conversion to be skipped and hence piggyback to be called with nonexistent files.
>>
>> Sparc64's rule also needs this fix.
>>
>> New patch tonight.
>
> Did you send this out and I just missed it somehow?

No, it's still "tonight" here, and will be for a few more hours.

I've gotten a much later start than intended, I'll test my change in
the next couple of hours and push out the patch after that.

Thanks,
David Miller - June 23, 2009, 11:31 a.m.
From: Julian Calaby <julian.calaby@gmail.com>
Date: Tue, 23 Jun 2009 21:29:06 +1000

> I've gotten a much later start than intended, I'll test my change in
> the next couple of hours and push out the patch after that.

Ok, no rush, I'll be asleep anyways :-)

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/sparc/boot/Makefile b/arch/sparc/boot/Makefile
index 500a2f8..043e661 100644
--- a/arch/sparc/boot/Makefile
+++ b/arch/sparc/boot/Makefile
@@ -58,7 +58,7 @@  $(obj)/image: $(obj)/btfix.o FORCE
 $(obj)/zImage: $(obj)/image
 	$(call if_changed,strip)
 
-$(obj)/tftpboot.img: $(obj)/piggyback_32 System.map $(ROOT_IMG) FORCE
+$(obj)/tftpboot.img: $(obj)/image $(obj)/piggyback_32 System.map $(ROOT_IMG) FORCE
 	$(call if_changed,elftoaout)
 	$(call if_changed,piggy)