| Message ID | 1383942318-12569-1-git-send-email-u.kleine-koenig@pengutronix.de |
|---|---|
| State | Rejected |
| Headers | show |
On Sat, Nov 9, 2013 at 4:25 AM, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > The symbol CLOCK_TICK_RATE is (at least on ARM) defined in an platform > specific header <mach/timex.h>. There are plans to stop using and kill > these platform specific headers. So fix the only user of pxa's > <mach/timex.h> to not use it. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > It would be nice to use the clk API to find the tick rate, but I didn't > find any clk to use. > --- > drivers/rtc/rtc-pxa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-pxa.c b/drivers/rtc/rtc-pxa.c > index a355f2b..0ba07e1 100644 > --- a/drivers/rtc/rtc-pxa.c > +++ b/drivers/rtc/rtc-pxa.c > @@ -32,7 +32,7 @@ > > #include <mach/hardware.h> > > -#define TIMER_FREQ CLOCK_TICK_RATE > +#define TIMER_FREQ get_clock_tick_rate() > #define RTC_DEF_DIVIDER (32768 - 1) > #define RTC_DEF_TRIM 0 > #define MAXFREQ_PERIODIC 1000 > -- > 1.7.10.4 > Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>
Hello, [Cc: += akpm] On Fri, Nov 08, 2013 at 09:25:18PM +0100, Uwe Kleine-König wrote: > The symbol CLOCK_TICK_RATE is (at least on ARM) defined in an platform > specific header <mach/timex.h>. There are plans to stop using and kill > these platform specific headers. So fix the only user of pxa's > <mach/timex.h> to not use it. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Who is looking for this patch? Best regards Uwe > --- > It would be nice to use the clk API to find the tick rate, but I didn't > find any clk to use. > --- > drivers/rtc/rtc-pxa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-pxa.c b/drivers/rtc/rtc-pxa.c > index a355f2b..0ba07e1 100644 > --- a/drivers/rtc/rtc-pxa.c > +++ b/drivers/rtc/rtc-pxa.c > @@ -32,7 +32,7 @@ > > #include <mach/hardware.h> > > -#define TIMER_FREQ CLOCK_TICK_RATE > +#define TIMER_FREQ get_clock_tick_rate() > #define RTC_DEF_DIVIDER (32768 - 1) > #define RTC_DEF_TRIM 0 > #define MAXFREQ_PERIODIC 1000 > -- > 1.7.10.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On 11/26/2013 09:37 PM, Uwe Kleine-König wrote: > Hello, > > [Cc: += akpm] > > On Fri, Nov 08, 2013 at 09:25:18PM +0100, Uwe Kleine-König wrote: >> The symbol CLOCK_TICK_RATE is (at least on ARM) defined in an platform >> specific header <mach/timex.h>. There are plans to stop using and kill >> these platform specific headers. So fix the only user of pxa's >> <mach/timex.h> to not use it. >> >> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Who is looking for this patch? > > Best regards > Uwe > >> --- >> It would be nice to use the clk API to find the tick rate, but I didn't >> find any clk to use. >> --- >> drivers/rtc/rtc-pxa.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/rtc/rtc-pxa.c b/drivers/rtc/rtc-pxa.c >> index a355f2b..0ba07e1 100644 >> --- a/drivers/rtc/rtc-pxa.c >> +++ b/drivers/rtc/rtc-pxa.c >> @@ -32,7 +32,7 @@ >> >> #include <mach/hardware.h> >> >> -#define TIMER_FREQ CLOCK_TICK_RATE >> +#define TIMER_FREQ get_clock_tick_rate() >> #define RTC_DEF_DIVIDER (32768 - 1) >> #define RTC_DEF_TRIM 0 >> #define MAXFREQ_PERIODIC 1000 >> -- >> 1.7.10.4 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com> I think that Alessandro could help to merge. Alessandro, Is it right? Regards Haojian
Haojian Zhuang <haojian.zhuang@gmail.com> writes: > On 11/26/2013 09:37 PM, Uwe Kleine-König wrote: >> Hello, >> >> [Cc: += akpm] >> >> On Fri, Nov 08, 2013 at 09:25:18PM +0100, Uwe Kleine-König wrote: >>> The symbol CLOCK_TICK_RATE is (at least on ARM) defined in an platform >>> specific header <mach/timex.h>. There are plans to stop using and kill >>> these platform specific headers. So fix the only user of pxa's n>>> <mach/timex.h> to not use it. >>> >>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> >> Who is looking for this patch? >> >> Best regards >> Uwe > Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com> > > I think that Alessandro could help to merge. > > Alessandro, > Is it right? Why won't you just remove TIMER_FREQ all together instead ? I don't remember why I put that in, but looking back at it, I don't find any use, so why don't we remove the line ? Cheers. -- Robert
diff --git a/drivers/rtc/rtc-pxa.c b/drivers/rtc/rtc-pxa.c index a355f2b..0ba07e1 100644 --- a/drivers/rtc/rtc-pxa.c +++ b/drivers/rtc/rtc-pxa.c @@ -32,7 +32,7 @@ #include <mach/hardware.h> -#define TIMER_FREQ CLOCK_TICK_RATE +#define TIMER_FREQ get_clock_tick_rate() #define RTC_DEF_DIVIDER (32768 - 1) #define RTC_DEF_TRIM 0 #define MAXFREQ_PERIODIC 1000
The symbol CLOCK_TICK_RATE is (at least on ARM) defined in an platform specific header <mach/timex.h>. There are plans to stop using and kill these platform specific headers. So fix the only user of pxa's <mach/timex.h> to not use it. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- It would be nice to use the clk API to find the tick rate, but I didn't find any clk to use. --- drivers/rtc/rtc-pxa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)