diff mbox

[3/3] acpi: method: add _CID control method test (LP: #1249174)

Message ID 1383882189-20997-3-git-send-email-alex.hung@canonical.com
State Accepted
Headers show

Commit Message

Alex Hung Nov. 8, 2013, 3:43 a.m. UTC
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/acpi/method/method.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Comments

Colin Ian King Nov. 8, 2013, 8:05 a.m. UTC | #1
On 08/11/13 03:43, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/method/method.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 05fb2bc..71c6a77 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -1002,6 +1002,12 @@ static int method_test_HID(fwts_framework *fw)
>  		"_HID", NULL, 0, method_test_HID_return, NULL);
>  }
>  
> +static int method_test_CID(fwts_framework *fw)
> +{
> +	return method_evaluate_method(fw, METHOD_OPTIONAL,
> +		"_CID", NULL, 0, method_test_HID_return, NULL);
> +}
> +
>  static int method_test_HRV(fwts_framework *fw)
>  {
>  	return method_evaluate_method(fw, METHOD_OPTIONAL,
> @@ -4817,7 +4823,7 @@ static fwts_framework_minor_test method_tests[] = {
>  
>  	/* Section 6.1 Device Identification Objects  */
>  
> -	/* { method_test_CID, "Check _CID (Compatible ID)." }, */
> +	{ method_test_CID, "Check _CID (Compatible ID)." },
>  	/* { method_test_CLS, "Check _CLS (Class Code)." }, */
>  	{ method_test_DDN, "Check _DDN (DOS Device Name)." },
>  	{ method_test_HID, "Check _HID (Hardware ID)." },
> 
Acked-by: Colin Ian King <colin.king@canonical.com>
Keng-Yu Lin Nov. 12, 2013, 7:20 a.m. UTC | #2
On Fri, Nov 8, 2013 at 4:05 PM, Colin Ian King <colin.king@canonical.com> wrote:
> On 08/11/13 03:43, Alex Hung wrote:
>> Signed-off-by: Alex Hung <alex.hung@canonical.com>
>> ---
>>  src/acpi/method/method.c | 8 +++++++-
>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
>> index 05fb2bc..71c6a77 100644
>> --- a/src/acpi/method/method.c
>> +++ b/src/acpi/method/method.c
>> @@ -1002,6 +1002,12 @@ static int method_test_HID(fwts_framework *fw)
>>               "_HID", NULL, 0, method_test_HID_return, NULL);
>>  }
>>
>> +static int method_test_CID(fwts_framework *fw)
>> +{
>> +     return method_evaluate_method(fw, METHOD_OPTIONAL,
>> +             "_CID", NULL, 0, method_test_HID_return, NULL);
>> +}
>> +
>>  static int method_test_HRV(fwts_framework *fw)
>>  {
>>       return method_evaluate_method(fw, METHOD_OPTIONAL,
>> @@ -4817,7 +4823,7 @@ static fwts_framework_minor_test method_tests[] = {
>>
>>       /* Section 6.1 Device Identification Objects  */
>>
>> -     /* { method_test_CID, "Check _CID (Compatible ID)." }, */
>> +     { method_test_CID, "Check _CID (Compatible ID)." },
>>       /* { method_test_CLS, "Check _CLS (Class Code)." }, */
>>       { method_test_DDN, "Check _DDN (DOS Device Name)." },
>>       { method_test_HID, "Check _HID (Hardware ID)." },
>>
> Acked-by: Colin Ian King <colin.king@canonical.com>
>

Acked-by: Keng-Yu Lin <kengyu@canonical.com>
diff mbox

Patch

diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
index 05fb2bc..71c6a77 100644
--- a/src/acpi/method/method.c
+++ b/src/acpi/method/method.c
@@ -1002,6 +1002,12 @@  static int method_test_HID(fwts_framework *fw)
 		"_HID", NULL, 0, method_test_HID_return, NULL);
 }
 
+static int method_test_CID(fwts_framework *fw)
+{
+	return method_evaluate_method(fw, METHOD_OPTIONAL,
+		"_CID", NULL, 0, method_test_HID_return, NULL);
+}
+
 static int method_test_HRV(fwts_framework *fw)
 {
 	return method_evaluate_method(fw, METHOD_OPTIONAL,
@@ -4817,7 +4823,7 @@  static fwts_framework_minor_test method_tests[] = {
 
 	/* Section 6.1 Device Identification Objects  */
 
-	/* { method_test_CID, "Check _CID (Compatible ID)." }, */
+	{ method_test_CID, "Check _CID (Compatible ID)." },
 	/* { method_test_CLS, "Check _CLS (Class Code)." }, */
 	{ method_test_DDN, "Check _DDN (DOS Device Name)." },
 	{ method_test_HID, "Check _HID (Hardware ID)." },