Patchwork mtd: gpmi-lib: Make checkpatch happy

login
register
mail settings
Submitter Fabio Estevam
Date Nov. 8, 2013, 1:28 a.m.
Message ID <1383874123-30125-1-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/289540/
State Accepted
Commit 76c930be3d4831b52d04aadc2522cfeeb7a6c789
Headers show

Comments

Fabio Estevam - Nov. 8, 2013, 1:28 a.m.
From: Fabio Estevam <fabio.estevam@freescale.com>

Fix the following checkpatch warnings:

WARNING: line over 80 characters
#268: FILE: mtd/nand/gpmi-nand/gpmi-lib.c:268:
+	* consecutive reboots. The latter case has not been seen on the MX23 yet,

WARNING: space prohibited before semicolon
#356: FILE: mtd/nand/gpmi-nand/gpmi-lib.c:356:
+		(target.tRHOH_in_ns >= 0) ;

WARNING: space prohibited before semicolon
#1006: FILE: mtd/nand/gpmi-nand/gpmi-lib.c:1006:
+		BF_GPMI_TIMING0_DATA_SETUP(hw.data_setup_in_cycles)       ;

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/mtd/nand/gpmi-nand/gpmi-lib.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Huang Shijie - Nov. 8, 2013, 2:26 a.m.
于 2013年11月08日 09:28, Fabio Estevam 写道:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Fix the following checkpatch warnings:
>
> WARNING: line over 80 characters
> #268: FILE: mtd/nand/gpmi-nand/gpmi-lib.c:268:
> +	* consecutive reboots. The latter case has not been seen on the MX23 yet,
>
> WARNING: space prohibited before semicolon
> #356: FILE: mtd/nand/gpmi-nand/gpmi-lib.c:356:
> +		(target.tRHOH_in_ns >= 0) ;
>
> WARNING: space prohibited before semicolon
> #1006: FILE: mtd/nand/gpmi-nand/gpmi-lib.c:1006:
> +		BF_GPMI_TIMING0_DATA_SETUP(hw.data_setup_in_cycles)       ;
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/mtd/nand/gpmi-nand/gpmi-lib.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
> index aaced29..c7a578c 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
> @@ -265,8 +265,8 @@ int bch_set_geometry(struct gpmi_nand_data *this)
>  	* chip, otherwise it will lock up. So we skip resetting BCH on the MX23.
>  	* On the other hand, the MX28 needs the reset, because one case has been
>  	* seen where the BCH produced ECC errors constantly after 10000
> -	* consecutive reboots. The latter case has not been seen on the MX23 yet,
> -	* still we don't know if it could happen there as well.
> +	* consecutive reboots. The latter case has not been seen on the MX23
> +	* yet, still we don't know if it could happen there as well.
>  	*/
>  	ret = gpmi_reset_block(r->bch_regs, GPMI_IS_MX23(this));
>  	if (ret)
> @@ -353,7 +353,7 @@ static int gpmi_nfc_compute_hardware_timing(struct gpmi_nand_data *this,
>  	improved_timing_is_available =
>  		(target.tREA_in_ns  >= 0) &&
>  		(target.tRLOH_in_ns >= 0) &&
> -		(target.tRHOH_in_ns >= 0) ;
> +		(target.tRHOH_in_ns >= 0);
>  
>  	/* Inspect the clock. */
>  	nfc->clock_frequency_in_hz = clk_get_rate(r->clock[0]);
> @@ -1003,7 +1003,7 @@ void gpmi_begin(struct gpmi_nand_data *this)
>  	/* [1] Set HW_GPMI_TIMING0 */
>  	reg = BF_GPMI_TIMING0_ADDRESS_SETUP(hw.address_setup_in_cycles) |
>  		BF_GPMI_TIMING0_DATA_HOLD(hw.data_hold_in_cycles)         |
> -		BF_GPMI_TIMING0_DATA_SETUP(hw.data_setup_in_cycles)       ;
> +		BF_GPMI_TIMING0_DATA_SETUP(hw.data_setup_in_cycles);
>  
>  	writel(reg, gpmi_regs + HW_GPMI_TIMING0);
>  
Acked-by: Huang Shijie <b32955@freescale.com>
Brian Norris - Nov. 13, 2013, 8:41 p.m.
On Thu, Nov 07, 2013 at 11:28:43PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Fix the following checkpatch warnings:
> 
> WARNING: line over 80 characters
> #268: FILE: mtd/nand/gpmi-nand/gpmi-lib.c:268:
> +	* consecutive reboots. The latter case has not been seen on the MX23 yet,
> 
> WARNING: space prohibited before semicolon
> #356: FILE: mtd/nand/gpmi-nand/gpmi-lib.c:356:
> +		(target.tRHOH_in_ns >= 0) ;
> 
> WARNING: space prohibited before semicolon
> #1006: FILE: mtd/nand/gpmi-nand/gpmi-lib.c:1006:
> +		BF_GPMI_TIMING0_DATA_SETUP(hw.data_setup_in_cycles)       ;
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Pushed to l2-mtd.git/next. Thanks!

Brian

Patch

diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
index aaced29..c7a578c 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c
@@ -265,8 +265,8 @@  int bch_set_geometry(struct gpmi_nand_data *this)
 	* chip, otherwise it will lock up. So we skip resetting BCH on the MX23.
 	* On the other hand, the MX28 needs the reset, because one case has been
 	* seen where the BCH produced ECC errors constantly after 10000
-	* consecutive reboots. The latter case has not been seen on the MX23 yet,
-	* still we don't know if it could happen there as well.
+	* consecutive reboots. The latter case has not been seen on the MX23
+	* yet, still we don't know if it could happen there as well.
 	*/
 	ret = gpmi_reset_block(r->bch_regs, GPMI_IS_MX23(this));
 	if (ret)
@@ -353,7 +353,7 @@  static int gpmi_nfc_compute_hardware_timing(struct gpmi_nand_data *this,
 	improved_timing_is_available =
 		(target.tREA_in_ns  >= 0) &&
 		(target.tRLOH_in_ns >= 0) &&
-		(target.tRHOH_in_ns >= 0) ;
+		(target.tRHOH_in_ns >= 0);
 
 	/* Inspect the clock. */
 	nfc->clock_frequency_in_hz = clk_get_rate(r->clock[0]);
@@ -1003,7 +1003,7 @@  void gpmi_begin(struct gpmi_nand_data *this)
 	/* [1] Set HW_GPMI_TIMING0 */
 	reg = BF_GPMI_TIMING0_ADDRESS_SETUP(hw.address_setup_in_cycles) |
 		BF_GPMI_TIMING0_DATA_HOLD(hw.data_hold_in_cycles)         |
-		BF_GPMI_TIMING0_DATA_SETUP(hw.data_setup_in_cycles)       ;
+		BF_GPMI_TIMING0_DATA_SETUP(hw.data_setup_in_cycles);
 
 	writel(reg, gpmi_regs + HW_GPMI_TIMING0);