From patchwork Thu Nov 7 22:25:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uros Bizjak X-Patchwork-Id: 289485 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 449F32C0079 for ; Fri, 8 Nov 2013 09:25:38 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:date:message-id:subject:from:to:cc:content-type; q=dns; s=default; b=JNxf5cq91CJoixKjk4G9gpYYmLRDoH2woptvY1wsaJT aL1xtpC6j2bd3RqP7iTXCLXxpw5N9onNdprPJiC3PIDxYDnsjNO/jS8QoTL6G27V ZB6stE0VYfxllxuz9g9lLKTLsyG4U0tzPMinJIv9DAU7+t8x/2Ousm2IFL82pDyQ = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:date:message-id:subject:from:to:cc:content-type; s=default; bh=LpMFwHlKmCiSirA2+7rqf5Lzi7U=; b=w4Lny4tPY2nYd1DXI WlozFH3nsVceB902Rn4u9DbJhmTPyGJCewMwhKc3bPPadAB192r5Xhw+i+JHSFzf erL2/wn5coRThTPd1CRXz22la2DDFc+IRtoSou567WkK0/NuBTMywuMDoorCuqdi JqWJnzYuo0WgJ+ISfHv6txOLjQ= Received: (qmail 24542 invoked by alias); 7 Nov 2013 22:25:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 24533 invoked by uid 89); 7 Nov 2013 22:25:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.0 required=5.0 tests=AWL, BAYES_50, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RDNS_NONE, SPAM_SUBJECT, SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-ob0-f181.google.com Received: from Unknown (HELO mail-ob0-f181.google.com) (209.85.214.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 07 Nov 2013 22:25:24 +0000 Received: by mail-ob0-f181.google.com with SMTP id wp4so742286obc.40 for ; Thu, 07 Nov 2013 14:25:15 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.182.40.201 with SMTP id z9mr1855276obk.45.1383863115713; Thu, 07 Nov 2013 14:25:15 -0800 (PST) Received: by 10.182.137.136 with HTTP; Thu, 7 Nov 2013 14:25:15 -0800 (PST) Date: Thu, 7 Nov 2013 23:25:15 +0100 Message-ID: Subject: Recent Go patch broke Alpha bootstrap From: Uros Bizjak To: "gcc-patches@gcc.gnu.org" Cc: Ian Lance Taylor Hello! Recent Go mega-patch broke Alpha bootstrap. Following fixlet is needed: --cut here-- newg->gcinitial_sp = *ret_stack; newg->gcstack_size = stacksize; --cut here-- However, all runtime tests panic with: gmake[2]: *** [os/check] Error 1 runtime: address space conflict: map(0xc000001000) = 0xc000002000 fatal error: runtime: address space conflict runtime stack: runtime_dopanic ../../../gcc-svn/trunk/libgo/runtime/panic.c:81 runtime_throw ../../../gcc-svn/trunk/libgo/runtime/panic.c:115 runtime_SysMap ../../../gcc-svn/trunk/libgo/runtime/mem.c:185 runtime_MHeap_MapSpans ../../../gcc-svn/trunk/libgo/runtime/mheap.c:81 runtime_MHeap_SysAlloc ../../../gcc-svn/trunk/libgo/runtime/malloc.goc:524 MHeap_Grow ../../../gcc-svn/trunk/libgo/runtime/mheap.c:241 MHeap_AllocLocked ../../../gcc-svn/trunk/libgo/runtime/mheap.c:126 runtime_MHeap_Alloc ../../../gcc-svn/trunk/libgo/runtime/mheap.c:95 runtime_mallocgc ../../../gcc-svn/trunk/libgo/runtime/malloc.goc:124 runtime_malg ../../../gcc-svn/trunk/libgo/runtime/proc.c:2101 __go_go ../../../gcc-svn/trunk/libgo/runtime/proc.c:2164 main ../../../gcc-svn/trunk/libgo/runtime/go-main.c:42 :0 :0 :0 The fixed place is mentioned in the trace, so I guess there is additional issue to fix. Uros. Index: runtime/proc.c =================================================================== --- runtime/proc.c (revision 204522) +++ runtime/proc.c (working copy) @@ -2098,7 +2098,7 @@ __splitstack_block_signals_context(&newg->stack_context[0], &dont_block_signals, nil); #else - *ret_stack = runtime_mallocgc(stacksize, FlagNoProfiling|FlagNoGC, 0, 0); + *ret_stack = runtime_mallocgc(stacksize, 0, FlagNoProfiling|FlagNoGC); *ret_stacksize = stacksize;