Patchwork [5/9] rtc-bfin: do not share RTC IRQ

login
register
mail settings
Submitter Alessandro Zummo
Date June 20, 2009, 4:09 p.m.
Message ID <20090620160902.6953.89778.stgit@i1501.lan.towertech.it>
Download mbox | patch
Permalink /patch/28936/
State Accepted
Headers show

Comments

Alessandro Zummo - June 20, 2009, 4:09 p.m.
From: Michael Hennerich <michael.hennerich@analog.com>

The Blackfin RTC IRQ is an internal interrupt, so it makes no sense to have
it be shared.

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Alessandro Zummo <a.zummo@towertech.it>
---

 drivers/rtc/rtc-bfin.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)



--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
-~----------~----~----~----~------~----~------~--~---
Mike Frysinger - Sept. 14, 2009, 3:39 a.m.
On Sat, Jun 20, 2009 at 12:09, Alessandro Zummo wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
>
> The Blackfin RTC IRQ is an internal interrupt, so it makes no sense to have
> it be shared.
>
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> Signed-off-by: Alessandro Zummo <a.zummo@towertech.it>

is this going to get merged for 2.6.32 ?  dont know why it wasnt
merged into 2.6.31 ...
-mike

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
-~----------~----~----~----~------~----~------~--~---
Andrew Morton - Sept. 14, 2009, 3:54 a.m.
On Sun, 13 Sep 2009 23:39:57 -0400 Mike Frysinger <vapier.adi@gmail.com> wrote:

> On Sat, Jun 20, 2009 at 12:09, Alessandro Zummo wrote:
> > From: Michael Hennerich <michael.hennerich@analog.com>
> >
> > The Blackfin RTC IRQ is an internal interrupt, so it makes no sense to have
> > it be shared.
> >
> > Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > Signed-off-by: Alessandro Zummo <a.zummo@towertech.it>
> 
> is this going to get merged for 2.6.32 ?

That's my intention.

>  dont know why it wasnt
> merged into 2.6.31 ...

Was received after -rc1 and there was nothing in the changelog which
indicated that it was needed in 2.6.31.


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
-~----------~----~----~----~------~----~------~--~---
Mike Frysinger - Sept. 14, 2009, 4:15 a.m.
On Sun, Sep 13, 2009 at 23:54, Andrew Morton wrote:
> On Sun, 13 Sep 2009 23:39:57 -0400 Mike Frysinger wrote:
>> On Sat, Jun 20, 2009 at 12:09, Alessandro Zummo wrote:
>> > From: Michael Hennerich <michael.hennerich@analog.com>
>> >
>> > The Blackfin RTC IRQ is an internal interrupt, so it makes no sense to have
>> > it be shared.
>> >
>> > Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
>> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>> > Signed-off-by: Alessandro Zummo <a.zummo@towertech.it>
>>
>> is this going to get merged for 2.6.32 ?
>
> That's my intention.
>
>>  dont know why it wasnt
>> merged into 2.6.31 ...
>
> Was received after -rc1 and there was nothing in the changelog which
> indicated that it was needed in 2.6.31.

np, thanks
-mike

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
-~----------~----~----~----~------~----~------~--~---

Patch

diff --git a/drivers/rtc/rtc-bfin.c b/drivers/rtc/rtc-bfin.c
index aafd3e6..abad9f6 100644
--- a/drivers/rtc/rtc-bfin.c
+++ b/drivers/rtc/rtc-bfin.c
@@ -375,7 +375,7 @@  static int __devinit bfin_rtc_probe(struct platform_device *pdev)
 	device_init_wakeup(dev, 1);
 
 	/* Grab the IRQ and init the hardware */
-	ret = request_irq(IRQ_RTC, bfin_rtc_interrupt, IRQF_SHARED, pdev->name, dev);
+	ret = request_irq(IRQ_RTC, bfin_rtc_interrupt, 0, pdev->name, dev);
 	if (unlikely(ret))
 		goto err;
 	/* sometimes the bootloader touched things, but the write complete was not