Patchwork powerpc/85xx: Make eSDHC 1-bit only transfer mode default for MPC8569E-MDS

login
register
mail settings
Submitter Anton Vorontsov
Date June 18, 2009, 11:37 p.m.
Message ID <20090618233752.GA13279@oksana.dev.rtsoft.ru>
Download mbox | patch
Permalink /patch/28889/
State Accepted
Commit 66c6b856d8738278a4a6e558d25c90e9950aa112
Delegated to: Kumar Gala
Headers show

Comments

Anton Vorontsov - June 18, 2009, 11:37 p.m.
For yet unknown reason 4-bit mode doesn't work on MPC8569E-MDS boards,
so make 1-bit mode default. When we resolve the issue, u-boot will
remove sdhci,1-bit-only property from the device tree, while SDHCI
will still work with older u-boots.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
 arch/powerpc/boot/dts/mpc8569mds.dts |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Kumar Gala - June 19, 2009, 2:25 a.m.
On Jun 18, 2009, at 6:37 PM, Anton Vorontsov wrote:

> For yet unknown reason 4-bit mode doesn't work on MPC8569E-MDS boards,
> so make 1-bit mode default. When we resolve the issue, u-boot will
> remove sdhci,1-bit-only property from the device tree, while SDHCI
> will still work with older u-boots.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> arch/powerpc/boot/dts/mpc8569mds.dts |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)

Did I miss the patch that adds this property defn. to our docs?

- k
Anton Vorontsov - June 19, 2009, 3:31 p.m.
On Thu, Jun 18, 2009 at 09:25:46PM -0500, Kumar Gala wrote:
>
> On Jun 18, 2009, at 6:37 PM, Anton Vorontsov wrote:
>
>> For yet unknown reason 4-bit mode doesn't work on MPC8569E-MDS boards,
>> so make 1-bit mode default. When we resolve the issue, u-boot will
>> remove sdhci,1-bit-only property from the device tree, while SDHCI
>> will still work with older u-boots.
>>
>> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>> ---
>> arch/powerpc/boot/dts/mpc8569mds.dts |    1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> Did I miss the patch that adds this property defn. to our docs?

Yep. ;-)

http://lists.ozlabs.org/pipermail/linuxppc-dev/2009-June/073394.html


Thanks,
Kumar Gala - June 19, 2009, 3:39 p.m.
On Jun 19, 2009, at 10:31 AM, Anton Vorontsov wrote:

> On Thu, Jun 18, 2009 at 09:25:46PM -0500, Kumar Gala wrote:
>>
>> On Jun 18, 2009, at 6:37 PM, Anton Vorontsov wrote:
>>
>>> For yet unknown reason 4-bit mode doesn't work on MPC8569E-MDS  
>>> boards,
>>> so make 1-bit mode default. When we resolve the issue, u-boot will
>>> remove sdhci,1-bit-only property from the device tree, while SDHCI
>>> will still work with older u-boots.
>>>
>>> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>>> ---
>>> arch/powerpc/boot/dts/mpc8569mds.dts |    1 +
>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> Did I miss the patch that adds this property defn. to our docs?
>
> Yep. ;-)
>
> http://lists.ozlabs.org/pipermail/linuxppc-dev/2009-June/073394.html

Ok.  I'll wait for Pierre to ack or pick up that patch before pulling  
in the .dts change.

- k
Kumar Gala - June 23, 2009, 1:04 p.m.
On Jun 18, 2009, at 6:37 PM, Anton Vorontsov wrote:

> For yet unknown reason 4-bit mode doesn't work on MPC8569E-MDS boards,
> so make 1-bit mode default. When we resolve the issue, u-boot will
> remove sdhci,1-bit-only property from the device tree, while SDHCI
> will still work with older u-boots.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
> arch/powerpc/boot/dts/mpc8569mds.dts |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)

applied to next

- k

Patch

diff --git a/arch/powerpc/boot/dts/mpc8569mds.dts b/arch/powerpc/boot/dts/mpc8569mds.dts
index 39c2927..63e8109 100644
--- a/arch/powerpc/boot/dts/mpc8569mds.dts
+++ b/arch/powerpc/boot/dts/mpc8569mds.dts
@@ -229,6 +229,7 @@ 
 			/* Filled in by U-Boot */
 			clock-frequency = <0>;
 			status = "disabled";
+			sdhci,1-bit-only;
 		};
 
 		crypto@30000 {