Patchwork [2/5] crc-itu-t: add bit-reversed calculation

login
register
mail settings
Submitter Dmitry Eremin-Solenikov
Date June 18, 2009, 2:26 p.m.
Message ID <1245335177-16810-3-git-send-email-dbaryshkov@gmail.com>
Download mbox | patch
Permalink /patch/28870/
State RFC
Delegated to: David Miller
Headers show

Comments

Dmitry Eremin-Solenikov - June 18, 2009, 2:26 p.m.
From: Darren Salt <linux@youmustbejoking.demon.co.uk>

Changes since original patch by Darren:
* add 'select BITREVERSE'
* fix kerneldoc

Signed-off-by: Darren Salt <linux@youmustbejoking.demon.co.uk>
Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
 include/linux/crc-itu-t.h |   10 ++++++++++
 lib/Kconfig               |    1 +
 lib/crc-itu-t.c           |   17 +++++++++++++++++
 3 files changed, 28 insertions(+), 0 deletions(-)

Patch

diff --git a/include/linux/crc-itu-t.h b/include/linux/crc-itu-t.h
index 84920f3..7b2b7ba 100644
--- a/include/linux/crc-itu-t.h
+++ b/include/linux/crc-itu-t.h
@@ -6,6 +6,9 @@ 
  *   Poly  0x0x1021 (x^16 + x^12 + x^15 + 1)
  *   Init  0
  *
+ * The bit-reversed buffer variants may be non-standard, but some firmware
+ * loaders require them.
+ *
  * This source code is licensed under the GNU General Public License,
  * Version 2. See the file COPYING for more details.
  */
@@ -14,15 +17,22 @@ 
 #define CRC_ITU_T_H
 
 #include <linux/types.h>
+#include <linux/bitrev.h>
 
 extern u16 const crc_itu_t_table[256];
 
 extern u16 crc_itu_t(u16 crc, const u8 *buffer, size_t len);
+extern u16 crc_itu_t_bitreversed(u16 crc, const u8 *buffer, size_t len);
 
 static inline u16 crc_itu_t_byte(u16 crc, const u8 data)
 {
 	return (crc << 8) ^ crc_itu_t_table[((crc >> 8) ^ data) & 0xff];
 }
 
+static inline u16 crc_itu_t_bitreversed_byte(u16 crc, const u8 data)
+{
+	return (crc << 8) ^ crc_itu_t_table[((crc >> 8) ^ bitrev8(data)) & 0xff];
+}
+
 #endif /* CRC_ITU_T_H */
 
diff --git a/lib/Kconfig b/lib/Kconfig
index 8ade0a7..0ec01c3 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -45,6 +45,7 @@  config CRC_T10DIF
 
 config CRC_ITU_T
 	tristate "CRC ITU-T V.41 functions"
+	select BITREVERSE
 	help
 	  This option is provided for the case where no in-kernel-tree
 	  modules require CRC ITU-T V.41 functions, but a module built outside
diff --git a/lib/crc-itu-t.c b/lib/crc-itu-t.c
index a63472b..a1422d8 100644
--- a/lib/crc-itu-t.c
+++ b/lib/crc-itu-t.c
@@ -64,6 +64,23 @@  u16 crc_itu_t(u16 crc, const u8 *buffer, size_t len)
 }
 EXPORT_SYMBOL(crc_itu_t);
 
+/**
+ * crc_itu_t_bitreversed - Compute the CRC-ITU-T for the bit-reversed data buffer;
+ *
+ * @crc:     previous CRC value
+ * @buffer:  data pointer
+ * @len:     number of bytes in the buffer
+ *
+ * Returns the updated CRC value
+ */
+u16 crc_itu_t_bitreversed(u16 crc, const u8 *buffer, size_t len)
+{
+	while (len--)
+		crc = crc_itu_t_bitreversed_byte(crc, *buffer++);
+	return crc;
+}
+EXPORT_SYMBOL(crc_itu_t_bitreversed);
+
 MODULE_DESCRIPTION("CRC ITU-T V.41 calculations");
 MODULE_LICENSE("GPL");