Patchwork [2.6.29.4] Blade 2000

login
register
mail settings
Submitter David Miller
Date June 18, 2009, 9:12 a.m.
Message ID <20090618.021255.113111736.davem@davemloft.net>
Download mbox | patch
Permalink /patch/28850/
State RFC
Delegated to: David Miller
Headers show

Comments

David Miller - June 18, 2009, 9:12 a.m.
From: BERTRAND Joël <joel.bertrand@systella.fr>
Date: Sun, 14 Jun 2009 14:40:51 +0200

> Git bisect view --stat returns :

Thanks for doing this work Bertrand.

Can you now try the following?  Using a fresh tree (you can just
"git bisect reset" that GIT tree you had) and apply the following
patch like this:

bash$ patch -p1 -R <test.patch

and see if that boots properly?

Thanks!

commit 7f977ddd0eedfd5aac7865794f220f65aae8f361
Author: Shyam_Iyer@Dell.com <Shyam_Iyer@Dell.com>
Date:   Thu Feb 5 20:12:37 2009 +0530

    [SCSI] qla2xxx: fix Kernel Panic with Qlogic 2472 Card.
    
    Kernel Panic is observed with a Qlogic 2472 Card is plugged into the
    system and the qla2xxx driver is loaded:
    
    QLogic Fibre Channel HBA Driver: 8.02.01.02.11.0-k9
    vendor=8086 device=3410
    qla2xxx 0000:05:00.0: PCI INT A -> GSI 40 (level, low) -> IRQ 40
    qla2xxx 0000:05:00.0: Found an ISP2432, irq 40, iobase
    0xffffc2001091c000
    qla2xxx 0000:05:00.0: Configuring PCI space...
    qla2xxx 0000:05:00.0: setting latency timer to 64
    qla2xxx 0000:05:00.0: Configure NVRAM parameters...
    BUG: unable to handle kernel NULL pointer dereference at
    0000000000000000
    IP: [<ffffffff8036319a>] strncpy+0x5/0x1e
    PGD 7c564067 PUD 78d8c067 PMD 0
    Oops: 0000 [1] SMP
    last sysfs file:
    /sys/devices/pci0000:00/0000:00:1d.1/usb6/6-2/6-2:1.1/input/input4/event
    4/dev
    CPU 1
    Modules linked in: qla2xxx(+) squashfs usb_storage scsi_transport_fc
    scsi_tgt parport_pc parport arc4 ecb crypto_blkcipher acpi_cpufreq fan
    loop nfs nfs_acl lockd sunrpc nls_iso8859_1 nls_cp437 ipv6 af_packet st
    sr_mod ide_disk ide_cd_mod ide_core cdrom usbhid hid ff_memless sg
    sd_mod crc_t10dif uhci_hcd mptsas mptscsih ehci_hcd mptbase
    scsi_transport_sas rtc_cmos rtc_core rtc_lib usbcore scsi_mod thermal
    bnx2 button processor thermal_sys hwmon edd
    Supported: Yes
    Pid: 4415, comm: insmod Not tainted 2.6.27.13-1-default #1
    RIP: 0010:[<ffffffff8036319a>] [<ffffffff8036319a>] strncpy+0x5/0x1e
    RSP: 0018:ffff88007b04fbc0 EFLAGS: 00010202
    RAX: 00000000000000b7 RBX: ffff88007b9641e0 RCX: ffff88007c1b2ad7
    RDX: 000000000000004f RSI: 0000000000000000 RDI: ffff88007c1b2ad7
    RBP: ffff88007c1b0620 R08: 0000000000000010 R09: 0000000100000000
    R10: 0000000000000046 R11: ffffffff803651c6 R12: ffff88007b074000
    R13: ffff88007b964000 R14: ffff88007c1b2ac6 R15: 0000000000000000
    FS: 00007f91a6c366f0(0000) GS:ffff88007dbeee40(0000)
    knlGS:0000000000000000
    CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
    CR2: 0000000000000000 CR3: 000000007bd7c000 CR4: 00000000000006e0
    DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
    DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
    Process insmod (pid: 4415, threadinfo ffff88007b04e000, task
    ffff880078586180)
    Stack: ffffffffa02d82c4 0000000000002432 ffff88007d385000
    ffff88007c1b0620
    ffff88007c1b0620 ffff88007c1b0000 ffff88007d385000 0000000000002432
    ffffffffa02dcb1e 0000000000002432 ffffc2001091c000 ffff88007c1b0620
    Call Trace:
    [<ffffffffa02d82c4>] qla24xx_nvram_config+0x385/0x6c2 [qla2xxx]
    [<ffffffffa02dcb1e>] qla2x00_initialize_adapter+0x169/0x383 [qla2xxx]
    [<ffffffffa02f2040>] qla2x00_probe_one+0x6bc/0x9c6 [qla2xxx]
    [<ffffffff8037346f>] pci_device_probe+0xb8/0x105
    [<ffffffff803e5a27>] really_probe+0xdd/0x1e5
    [<ffffffff803e5c14>] __driver_attach+0x46/0x6d
    [<ffffffff803e51e1>] bus_for_each_dev+0x44/0x78
    [<ffffffff803e4ac7>] bus_add_driver+0xef/0x235
    [<ffffffff803e5dd8>] driver_register+0xa2/0x11f
    [<ffffffff803736fd>] __pci_register_driver+0x5d/0x90
    [<ffffffffa0308126>] qla2x00_module_init+0x126/0x159 [qla2xxx]
    [<ffffffff80209041>] _stext+0x41/0x110
    [<ffffffff80260abd>] sys_init_module+0xa0/0x1ba
    [<ffffffff8020bfbb>] system_call_fastpath+0x16/0x1b
    [<00007f91a679b76a>] 0x7f91a679b76a
    Code: ff c1 41 39 c0 75 05 45 85 c0 75 bf 41 29 c0 44 89 c0 c3 31 d2 8a
    04 16 88 04 17 48 ff c2 84 c0 75 f3 48 89 f8 c3 48 89 f9 eb 10 <8a> 06
    3c 01 88 01 48 83 de ff 48 ff c1 48 ff ca 48 85 d2 75 eb
    RIP [<ffffffff8036319a>] strncpy+0x5/0x1e
    RSP <ffff88007b04fbc0>
    CR2: 0000000000000000
    ---[ end trace 829d7d78dfafb785 ]---
    
    The attached patch fixes the issue.
    
    Signed-off-by: Shyam Iyer <shyam_iyer@dell.com>
    Acked-by: Seokmann Ju <Seokmann.ju@qlogic.com>
    Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/scsi/qla2xxx/qla_devtbl.h b/drivers/scsi/qla2xxx/qla_devtbl.h
index d78d35e..d6ea69d 100644
--- a/drivers/scsi/qla2xxx/qla_devtbl.h
+++ b/drivers/scsi/qla2xxx/qla_devtbl.h
@@ -72,7 +72,7 @@  static char *qla2x00_model_name[QLA_MODEL_NAMES*2] = {
 	"QLA2462",	"Sun PCI-X 2.0 to 4Gb FC, Dual Channel",	/* 0x141 */
 	"QLE2460",	"Sun PCI-Express to 2Gb FC, Single Channel",	/* 0x142 */
 	"QLE2462",	"Sun PCI-Express to 4Gb FC, Single Channel",	/* 0x143 */
-	"QEM2462"	"Server I/O Module 4Gb FC, Dual Channel",	/* 0x144 */
+	"QEM2462",	"Server I/O Module 4Gb FC, Dual Channel",	/* 0x144 */
 	"QLE2440",	"PCI-Express to 4Gb FC, Single Channel",	/* 0x145 */
 	"QLE2464",	"PCI-Express to 4Gb FC, Quad Channel",		/* 0x146 */
 	"QLA2440",	"PCI-X 2.0 to 4Gb FC, Single Channel",		/* 0x147 */