From patchwork Mon Nov 4 20:34:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 288250 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ozlabs.org (Postfix) with ESMTP id 9F1CF2C016B for ; Tue, 5 Nov 2013 07:34:33 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id D38A28F5B2; Mon, 4 Nov 2013 20:34:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FyQZ9Hvb8RUp; Mon, 4 Nov 2013 20:34:29 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 2F7508E252; Mon, 4 Nov 2013 20:34:29 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 0FC1B1BFAAB for ; Mon, 4 Nov 2013 20:34:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 07C6E8E252 for ; Mon, 4 Nov 2013 20:34:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wkUNjP2cVa2A for ; Mon, 4 Nov 2013 20:34:27 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ea0-f181.google.com (mail-ea0-f181.google.com [209.85.215.181]) by whitealder.osuosl.org (Postfix) with ESMTPS id 160CF8D24C for ; Mon, 4 Nov 2013 20:34:26 +0000 (UTC) Received: by mail-ea0-f181.google.com with SMTP id d10so3665726eaj.26 for ; Mon, 04 Nov 2013 12:34:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:content-transfer-encoding:subject :message-id:user-agent:date:from:to; bh=b/EozZZD8/GwhYEdz9TMidiv08Ro/b4tzPLtJcEQ1No=; b=ImASZO/Y2Vi/5GAIAfgy0kFNsobAzjw9Nypqv89T2jP/HtSCojudjAwW7AlFy0Iuxd 5sAIWQ9qCtgkcIK28n3l5qX+76mMGgzELHQalCLfGWE1l0WV8YMsPz6q0ctDeI/W0Szq G0XZSQFXbLDHsgZpSNWw4DurECtmSPXegBk/lYanmqN2nHvrKtFpiWZgAbxv66rV8fVE eeERK9ZLITWfgrVQSZGR38RtX3stSeABE2VAFx7dXVNSG3MG2AeNJekanq73TS6SB46f 1Mf0YCIuwHoNwpTT0OXRS2b1rWUVdioB34pgI75rcKjTJN8aMkWCB3hIFL0ITqilFuXH Cxmg== X-Received: by 10.15.50.68 with SMTP id k44mr9286899eew.54.1383597265230; Mon, 04 Nov 2013 12:34:25 -0800 (PST) Received: from [127.0.1.1] (d54C62EEB.access.telenet.be. [84.198.46.235]) by mx.google.com with ESMTPSA id y7sm1666358eea.5.2013.11.04.12.34.21 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 04 Nov 2013 12:34:24 -0800 (PST) MIME-Version: 1.0 X-Mercurial-Node: 94085e779250785b898635f2821df66aac6dff0e Message-Id: <94085e779250785b8986.1383597255@argentina> User-Agent: Mercurial-patchbomb/2.2.2 Date: Mon, 04 Nov 2013 21:34:15 +0100 From: Thomas De Schampheleire To: buildroot@busybox.net Subject: [Buildroot] [PATCH] manual: clarify that Config.in comments should have correct dependencies X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net Signed-off-by: Thomas De Schampheleire Acked-by: Samuel Martin --- Note: this documentation patch accompanies my earlier patch of today to add missing dependencies on such comments [1]. These two should have been sent as one series, sorry for that. [1] http://patchwork.ozlabs.org/patch/288125/ docs/manual/adding-packages-directory.txt | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt --- a/docs/manual/adding-packages-directory.txt +++ b/docs/manual/adding-packages-directory.txt @@ -171,6 +171,7 @@ C library, C++ support, largefile suppor IPv6 support, wchar support, or dynamic library support. Some packages can only be built on certain target architectures, or if an MMU is available in the processor. + These dependencies have to expressed with the appropriate 'depends on' statements in the Config.in file. Additionally, for dependencies on toolchain options, a +comment+ should be displayed when the option is @@ -180,6 +181,14 @@ made visible in a comment: since it is u freely choose another target, it makes little sense to show these dependencies explicitly. +The +comment+ should only be visible if the +config+ option itself would +be visible when the toolchain option dependencies are met. This means +that all other dependencies of the package (including dependencies on +target architecture and MMU support) have to be repeated on the ++comment+ definition. To keep it clear, the +depends on+ statement for +these non-toolchain option should be kept separate from the +depends on+ +statement for the toolchain options. + The general format of a dependency +comment+ for package foo is: -------------------------- foo needs a toolchain w/ featA, featB, featC