diff mbox

libsigsegv: fix avr32 build

Message ID 1383557629-13227-1-git-send-email-spdawson@gmail.com
State Superseded
Headers show

Commit Message

Simon Dawson Nov. 4, 2013, 9:33 a.m. UTC
From: Simon Dawson <spdawson@gmail.com>

The libsigsegv configure step fails to correctly figure out the direction of
stack growth for avr32. This leads to a zero STACK_DIRECTION definition, and
build failures such as the following.

  http://autobuild.buildroot.net/results/a3fe938f9376533b4777d79deb7a2ee83ed5ce33

Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
 .../libsigsegv-0001-fix-avr32-build.patch          | 32 ++++++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 package/libsigsegv/libsigsegv-0001-fix-avr32-build.patch

Comments

Peter Korsgaard Nov. 4, 2013, 9:35 p.m. UTC | #1
>>>>> "spdawson" == spdawson  <spdawson@gmail.com> writes:

 > From: Simon Dawson <spdawson@gmail.com>
 > The libsigsegv configure step fails to correctly figure out the direction of
 > stack growth for avr32. This leads to a zero STACK_DIRECTION definition, and
 > build failures such as the following.

 >   http://autobuild.buildroot.net/results/a3fe938f9376533b4777d79deb7a2ee83ed5ce33

 > Signed-off-by: Simon Dawson <spdawson@gmail.com>
 > ---
 >  .../libsigsegv-0001-fix-avr32-build.patch          | 32 ++++++++++++++++++++++
 >  1 file changed, 32 insertions(+)
 >  create mode 100644 package/libsigsegv/libsigsegv-0001-fix-avr32-build.patch

 > diff --git a/package/libsigsegv/libsigsegv-0001-fix-avr32-build.patch b/package/libsigsegv/libsigsegv-0001-fix-avr32-build.patch
 > new file mode 100644
 > index 0000000..daccabb
 > --- /dev/null
 > +++ b/package/libsigsegv/libsigsegv-0001-fix-avr32-build.patch
 > @@ -0,0 +1,32 @@
 > +The libsigsegv configure step fails to correctly figure out the direction of
 > +stack growth for avr32. This leads to a zero STACK_DIRECTION definition, and
 > +build failures such as the following.
 > +
 > +  http://autobuild.buildroot.net/results/a3fe938f9376533b4777d79deb7a2ee83ed5ce33
 > +
 > +Signed-off-by: Simon Dawson <spdawson@gmail.com>
 > +
 > +diff -Nurp a/configure b/configure

Doesn't autoreconf work? I prefer to regenerate configure instead of
patching it if possible.
Simon Dawson Nov. 5, 2013, 7:43 a.m. UTC | #2
Thanks for the feedback Peter.

On 4 November 2013 21:35, Peter Korsgaard <jacmet@uclibc.org> wrote:
> Doesn't autoreconf work? I prefer to regenerate configure instead of
> patching it if possible.

Yes, that works. Will submit an updated patch.

Simon.
diff mbox

Patch

diff --git a/package/libsigsegv/libsigsegv-0001-fix-avr32-build.patch b/package/libsigsegv/libsigsegv-0001-fix-avr32-build.patch
new file mode 100644
index 0000000..daccabb
--- /dev/null
+++ b/package/libsigsegv/libsigsegv-0001-fix-avr32-build.patch
@@ -0,0 +1,32 @@ 
+The libsigsegv configure step fails to correctly figure out the direction of
+stack growth for avr32. This leads to a zero STACK_DIRECTION definition, and
+build failures such as the following.
+
+  http://autobuild.buildroot.net/results/a3fe938f9376533b4777d79deb7a2ee83ed5ce33
+
+Signed-off-by: Simon Dawson <spdawson@gmail.com>
+
+diff -Nurp a/configure b/configure
+--- a/configure	2011-04-03 16:50:50.000000000 +0100
++++ b/configure	2013-11-04 09:29:21.990050318 +0000
+@@ -14504,7 +14504,7 @@ else
+       alpha* | \
+       arc | \
+       arm* | strongarm* | xscale* | \
+-      avr | \
++      avr | avr32 | \
+       c1 | c2 | c32 | c34 | c38 | \
+       clipper | \
+       cris | \
+diff -Nurp a/m4/stack-direction.m4 b/m4/stack-direction.m4
+--- a/m4/stack-direction.m4	2009-11-21 12:22:45.000000000 +0000
++++ b/m4/stack-direction.m4	2013-11-04 09:29:27.558036038 +0000
+@@ -16,7 +16,7 @@ AC_DEFUN([SV_STACK_DIRECTION],
+       alpha* | \
+       arc | \
+       arm* | strongarm* | xscale* | \
+-      avr | \
++      avr | avr32 | \
+       c1 | c2 | c32 | c34 | c38 | \
+       clipper | \
+       cris | \