diff mbox

[v2] netperf: enable demo mode.

Message ID 1383531561-5550-1-git-send-email-keguang.zhang@gmail.com
State Accepted
Headers show

Commit Message

Keguang Zhang Nov. 4, 2013, 2:19 a.m. UTC
Enable demo mode for netperf to activates a global "-D" <interval> option.
This option will display interim results at least every time interval.

Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
---
 package/netperf/netperf.mk |    1 +
 1 file changed, 1 insertion(+)

Comments

Arnout Vandecappelle Nov. 4, 2013, 7:35 p.m. UTC | #1
On 04/11/13 03:19, Kelvin Cheung wrote:
> Enable demo mode for netperf to activates a global "-D" <interval> option.
> This option will display interim results at least every time interval.
>
> Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

  On x86_64 with glibc, this makes a difference of 3K (<2%) on the 
netperf and netserver executables. So I think it's OK to enable it 
unconditionally.

  Regards,
  Arnout

> ---
>   package/netperf/netperf.mk |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/package/netperf/netperf.mk b/package/netperf/netperf.mk
> index 2bd11f3..455f27e 100644
> --- a/package/netperf/netperf.mk
> +++ b/package/netperf/netperf.mk
> @@ -7,6 +7,7 @@
>   NETPERF_VERSION = 2.6.0
>   NETPERF_SITE = ftp://ftp.netperf.org/netperf
>   NETPERF_CONF_ENV = ac_cv_func_setpgrp_void=set
> +NETPERF_CONF_OPT = --enable-demo=yes
>   NETPERF_LICENSE = netperf license
>   NETPERF_LICENSE_FILES = COPYING
>
>
Peter Korsgaard Nov. 4, 2013, 9:33 p.m. UTC | #2
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

 > On 04/11/13 03:19, Kelvin Cheung wrote:
 >> Enable demo mode for netperf to activates a global "-D" <interval> option.
 >> This option will display interim results at least every time interval.
 >> 
 >> Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>

 > Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 >  On x86_64 with glibc, this makes a difference of 3K (<2%) on the
 > netperf and netserver executables. So I think it's OK to enable it
 > unconditionally.

Agreed. It is +4K here (uClibc, ARM).
Peter Korsgaard Nov. 4, 2013, 9:34 p.m. UTC | #3
>>>>> "Kelvin" == Kelvin Cheung <keguang.zhang@gmail.com> writes:

 > Enable demo mode for netperf to activates a global "-D" <interval> option.
 > This option will display interim results at least every time interval.

 > Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>

Committed, thanks.
diff mbox

Patch

diff --git a/package/netperf/netperf.mk b/package/netperf/netperf.mk
index 2bd11f3..455f27e 100644
--- a/package/netperf/netperf.mk
+++ b/package/netperf/netperf.mk
@@ -7,6 +7,7 @@ 
 NETPERF_VERSION = 2.6.0
 NETPERF_SITE = ftp://ftp.netperf.org/netperf
 NETPERF_CONF_ENV = ac_cv_func_setpgrp_void=set
+NETPERF_CONF_OPT = --enable-demo=yes
 NETPERF_LICENSE = netperf license
 NETPERF_LICENSE_FILES = COPYING