| Message ID | CADNgcEyoTRq2Zxxd980a=RdLjN+H7Qgz48JSH3dx-Rx+_8d4Mw@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
On Mon, 4 Nov 2013, Mingjie Xing wrote: > Hello, > > This patch forces options Wa, Wl, Wp, to take a mandatory argument, > which can fix the bug > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55651. > > Tested on i686-pc-linux-gnu. > > 2013-11-04 Mingjie Xing <mingjie.xing@gmail.com> > > * common.opt (Wa, Wl, Wp,): Change JoinedOrMissing to Joined. > > Is it OK? As discussed in the thread starting at <http://gcc.gnu.org/ml/gcc-patches/2010-04/msg00848.html>, this is incorrect; these options should pass through empty strings unchanged.
Index: gcc/common.opt =================================================================== --- gcc/common.opt (revision 204285) +++ gcc/common.opt (working copy) @@ -497,13 +497,13 @@ Common RejectNegative Warning Alias(Wext This switch is deprecated; use -Wextra instead Wa, -Driver JoinedOrMissing +Driver Joined Wl, -Driver JoinedOrMissing +Driver Joined Wp, -Driver JoinedOrMissing +Driver Joined Waggregate-return Common Var(warn_aggregate_return) Warning
Hello, This patch forces options Wa, Wl, Wp, to take a mandatory argument, which can fix the bug http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55651. Tested on i686-pc-linux-gnu. 2013-11-04 Mingjie Xing <mingjie.xing@gmail.com> * common.opt (Wa, Wl, Wp,): Change JoinedOrMissing to Joined. Is it OK? Mingjie