Patchwork [U-Boot] config: arm: exynos5250: remove duplicate defines

login
register
mail settings
Submitter Luka Perkov
Date Nov. 4, 2013, 1:12 a.m.
Message ID <1383527520-13048-1-git-send-email-luka@openwrt.org>
Download mbox | patch
Permalink /patch/288098/
State Accepted
Delegated to: Minkyu Kang
Headers show

Comments

Luka Perkov - Nov. 4, 2013, 1:12 a.m.
The SPI section is already defined in this file (lines 268-288) so we can
remove the duplicate definitions. While at it, also fix one tiny whitespace
typo.

Signed-off-by: Luka Perkov <luka@openwrt.org>
---
 include/configs/exynos5250-dt.h | 23 +----------------------
 1 file changed, 1 insertion(+), 22 deletions(-)
Minkyu Kang - Nov. 29, 2013, 12:54 a.m.
Dear Luka Perkov,

On 04/11/13 10:12, Luka Perkov wrote:
> The SPI section is already defined in this file (lines 268-288) so we can
> remove the duplicate definitions. While at it, also fix one tiny whitespace
> typo.
> 
> Signed-off-by: Luka Perkov <luka@openwrt.org>
> ---
>  include/configs/exynos5250-dt.h | 23 +----------------------
>  1 file changed, 1 insertion(+), 22 deletions(-)
> 

applied to u-boot-samsung.

Thanks,
Minkyu Kang.

Patch

diff --git a/include/configs/exynos5250-dt.h b/include/configs/exynos5250-dt.h
index 8c07d8f..c168439 100644
--- a/include/configs/exynos5250-dt.h
+++ b/include/configs/exynos5250-dt.h
@@ -257,7 +257,7 @@ 
 #define CONFIG_DRIVER_S3C24X0_I2C
 #define CONFIG_I2C_MULTI_BUS
 #define CONFIG_MAX_I2C_NUM	8
-#define CONFIG_SYS_I2C_SLAVE    0x0
+#define CONFIG_SYS_I2C_SLAVE	0x0
 #define CONFIG_I2C_EDID
 
 /* PMIC */
@@ -292,27 +292,6 @@ 
 #define CONFIG_POWER_I2C
 #define CONFIG_POWER_MAX77686
 
-/* SPI */
-#define CONFIG_ENV_IS_IN_SPI_FLASH
-#define CONFIG_SPI_FLASH
-
-#ifdef CONFIG_SPI_FLASH
-#define CONFIG_EXYNOS_SPI
-#define CONFIG_CMD_SF
-#define CONFIG_CMD_SPI
-#define CONFIG_SPI_FLASH_WINBOND
-#define CONFIG_SF_DEFAULT_MODE		SPI_MODE_0
-#define CONFIG_SF_DEFAULT_SPEED		50000000
-#define EXYNOS5_SPI_NUM_CONTROLLERS	5
-#endif
-
-#ifdef CONFIG_ENV_IS_IN_SPI_FLASH
-#define CONFIG_ENV_SPI_MODE	SPI_MODE_0
-#define CONFIG_ENV_SECT_SIZE	CONFIG_ENV_SIZE
-#define CONFIG_ENV_SPI_BUS	1
-#define CONFIG_ENV_SPI_MAX_HZ	50000000
-#endif
-
 /* Ethernet Controllor Driver */
 #ifdef CONFIG_CMD_NET
 #define CONFIG_SMC911X