Patchwork [U-Boot,2/2] wandboard: Return the error when cpu_eth_init() fails

login
register
mail settings
Submitter Fabio Estevam
Date Nov. 4, 2013, 12:03 a.m.
Message ID <1383523384-6090-2-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/288087/
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Comments

Fabio Estevam - Nov. 4, 2013, 12:03 a.m.
From: Fabio Estevam <fabio.estevam@freescale.com>

When cpu_eth_init() fails we should not return success.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/wandboard/wandboard.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Stefano Babic - Nov. 13, 2013, 9:15 a.m.
On 04/11/2013 01:03, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> When cpu_eth_init() fails we should not return success.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Patch

diff --git a/board/wandboard/wandboard.c b/board/wandboard/wandboard.c
index 99150f9..bf9898c 100644
--- a/board/wandboard/wandboard.c
+++ b/board/wandboard/wandboard.c
@@ -265,7 +265,7 @@  int board_eth_init(bd_t *bis)
 	if (ret)
 		printf("FEC MXC: %s:failed\n", __func__);
 
-	return 0;
+	return ret;
 }
 
 int board_early_init_f(void)