Patchwork [1,of,2,v2] manual: github commits should be specified in full

login
register
mail settings
Submitter Thomas De Schampheleire
Date Nov. 2, 2013, 1:22 p.m.
Message ID <f6fb6654af62045239ca.1383398537@argentina>
Download mbox | patch
Permalink /patch/287980/
State Superseded
Headers show

Comments

Thomas De Schampheleire - Nov. 2, 2013, 1:22 p.m.
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

---
v2: remove parentheses around 'full' (comment Samuel)

 docs/manual/adding-packages-tips.txt |  5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
Thomas Petazzoni - Nov. 2, 2013, 1:44 p.m.
Dear Thomas De Schampheleire,

On Sat, 02 Nov 2013 14:22:17 +0100, Thomas De Schampheleire wrote:

> @@ -53,5 +53,4 @@ FOO_SITE = http://github.com/<user>/<pac
>  - The tarball name generated by github matches the default one from
>    Buildroot (e.g.: +foo-1234567.tar.gz+),

Samuel also suggested that this example should use a full git commit
ID, no?

Thomas
Thomas De Schampheleire - Nov. 2, 2013, 2:51 p.m.
Hi Thomas,

On Sat, Nov 2, 2013 at 2:44 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Thomas De Schampheleire,
>
> On Sat, 02 Nov 2013 14:22:17 +0100, Thomas De Schampheleire wrote:
>
>> @@ -53,5 +53,4 @@ FOO_SITE = http://github.com/<user>/<pac
>>  - The tarball name generated by github matches the default one from
>>    Buildroot (e.g.: +foo-1234567.tar.gz+),
>
> Samuel also suggested that this example should use a full git commit
> ID, no?

Oh, I did totally not see that comment.
My apologies, I'll resubmit...

Best regards,
Thomas

Patch

diff --git a/docs/manual/adding-packages-tips.txt b/docs/manual/adding-packages-tips.txt
--- a/docs/manual/adding-packages-tips.txt
+++ b/docs/manual/adding-packages-tips.txt
@@ -44,7 +44,7 @@  However, it is possible to download tarb
 on github.
 
 ------------------------
-FOO_VERSION = v1.0 # tag or (abbreviated) commit ID
+FOO_VERSION = v1.0 # tag or full commit ID
 FOO_SITE = http://github.com/<user>/<package>/tarball/$(FOO_VERSION)
 ------------------------
 
@@ -53,5 +53,4 @@  FOO_SITE = http://github.com/<user>/<pac
 - The tarball name generated by github matches the default one from
   Buildroot (e.g.: +foo-1234567.tar.gz+),
   so it is not necessary to specify it in the +.mk+ file.
-- When using a commit ID as version, usually the first 7 characters of
-  the SHA1 are enough.
+- When using a commit ID as version, you should use the full 40 hex characters.