From patchwork Wed Jun 17 13:34:52 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Rothwell X-Patchwork-Id: 28788 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id DED77B7252 for ; Wed, 17 Jun 2009 23:35:32 +1000 (EST) Received: by ozlabs.org (Postfix) id C4F38DDDA0; Wed, 17 Jun 2009 23:35:32 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id EFBCFDDDB2 for ; Wed, 17 Jun 2009 23:35:31 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765739AbZFQNew (ORCPT ); Wed, 17 Jun 2009 09:34:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760203AbZFQNew (ORCPT ); Wed, 17 Jun 2009 09:34:52 -0400 Received: from chilli.pcug.org.au ([203.10.76.44]:51068 "EHLO smtps.tip.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933307AbZFQNeu (ORCPT ); Wed, 17 Jun 2009 09:34:50 -0400 Received: from canb.auug.org.au (ta-1-1.tip.net.au [203.11.71.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtps.tip.net.au (Postfix) with ESMTPSA id 7ECD0368025; Wed, 17 Jun 2009 23:34:50 +1000 (EST) Date: Wed, 17 Jun 2009 23:34:52 +1000 From: Stephen Rothwell To: Kumar Gala Cc: subrata@linux.vnet.ibm.com, netdev@vger.kernel.org, Li Yang , Nathan Lynch , Sachin P Sant , Linux-Next , Linux-Kernel , Balbir Singh , Linuxppc-dev , Tony Breeds , michael@ellerman.id.au, Haiying Wang , "David S. Miller" , Grant Likely Subject: Re: [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o] Message-Id: <20090617233452.03ac78d5.sfr@canb.auug.org.au> In-Reply-To: <20090617232341.c4543ff2.sfr@canb.auug.org.au> References: <20090611033705.20842.75501.sendpatchset@subratamodak.linux.ibm.com> <1245048719.5239.10.camel@subratamodak.linux.ibm.com> <1245243097.4870.3.camel@subratamodak.linux.ibm.com> <6E26D0A1-0FE5-4179-9DA8-FDF0E3D417DA@kernel.crashing.org> <20090617232341.c4543ff2.sfr@canb.auug.org.au> X-Mailer: Sylpheed 2.6.0 (GTK+ 2.16.2; i486-pc-linux-gnu) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 17 Jun 2009 23:23:41 +1000 Stephen Rothwell wrote: > > Hi Kumar, > > On Wed, 17 Jun 2009 08:07:47 -0500 Kumar Gala wrote: > > > > > > I'm confused by the proposed fix as we already have *mdio & *ph > > defined in this function: > > Which tree are you looking at? Linus' tree, and linux-next, do not have > those local variables ... Hmmm, commit 0b9da337dca972e7a4144e298ec3adb8f244d4a4 ("net: Rework ucc_geth driver to use of_mdio infrastructure") removed the locals along with their usages, then commit 047584ce94108012288554a5f84585d792cc7f8f ("net/ucc_geth: Add SGMII support for UEC GETH driver") added more uses without adding the variables back. Here is the patch again: From: Subrata Modak Subject: [PATCH] Fix build error in ucc_geth.c Fix the following build error: drivers/net/ucc_geth.c: In function bucc_geth_probeb: drivers/net/ucc_geth.c:3822: error: 'ph' undeclared (first use in this function) drivers/net/ucc_geth.c:3822: error: (Each undeclared identifier is reported only once drivers/net/ucc_geth.c:3822: error: for each function it appears in.) drivers/net/ucc_geth.c:3832: error: 'mdio' undeclared (first use in this function) make[2]: *** [drivers/net/ucc_geth.o] Error 1 Signed-off-by: Subrata Modak --- linux-2.6.30-rc8/drivers/net/ucc_geth.c.orig 2009-06-10 11:58:39.000000000 -0500 +++ linux-2.6.30-rc8/drivers/net/ucc_geth.c 2009-06-10 22:28:13.000000000 -0500 @@ -3595,6 +3595,8 @@ static const struct net_device_ops ucc_g static int ucc_geth_probe(struct of_device* ofdev, const struct of_device_id *match) { + struct device_node *mdio; + const phandle *ph; struct device *device = &ofdev->dev; struct device_node *np = ofdev->node; struct net_device *dev = NULL;