Patchwork Small fix: add { dg-require-effective-target vect_int } to testsuite/gcc.dg/vect/pr58508.c

login
register
mail settings
Submitter Cong Hou
Date Nov. 1, 2013, 5:47 p.m.
Message ID <CAK=A3=3gdYEXHdvpKCejEKXGKHqqCCLzbFbHQdPcGRYjs9uOWA@mail.gmail.com>
Download mbox | patch
Permalink /patch/287877/
State New
Headers show

Comments

Cong Hou - Nov. 1, 2013, 5:47 p.m.
It seems that on some platforms the loops in
testsuite/gcc.dg/vect/pr58508.c may be unable to be vectorized. This
small patch added { dg-require-effective-target vect_int } to make
sure all loops can be vectorized.


thanks,
Cong
Cong Hou - Nov. 8, 2013, 2:24 a.m.
Ping. OK for the trunk?




thanks,
Cong


On Fri, Nov 1, 2013 at 10:47 AM, Cong Hou <congh@google.com> wrote:
> It seems that on some platforms the loops in
> testsuite/gcc.dg/vect/pr58508.c may be unable to be vectorized. This
> small patch added { dg-require-effective-target vect_int } to make
> sure all loops can be vectorized.
>
>
> thanks,
> Cong
>
>
> diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
> index 9d0f4a5..3d9916d 100644
> --- a/gcc/testsuite/ChangeLog
> +++ b/gcc/testsuite/ChangeLog
> @@ -1,3 +1,7 @@
> +2013-10-29  Cong Hou  <congh@google.com>
> +
> +       * gcc.dg/vect/pr58508.c: Update.
> +
>  2013-10-15  Cong Hou  <congh@google.com>
>
>         * gcc.dg/vect/pr58508.c: New test.
> diff --git a/gcc/testsuite/gcc.dg/vect/pr58508.c
> b/gcc/testsuite/gcc.dg/vect/pr58508.c
> index 6484a65..fff7a04 100644
> --- a/gcc/testsuite/gcc.dg/vect/pr58508.c
> +++ b/gcc/testsuite/gcc.dg/vect/pr58508.c
> @@ -1,3 +1,4 @@
> +/* { dg-require-effective-target vect_int } */
>  /* { dg-do compile } */
>  /* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */
Richard Guenther - Nov. 8, 2013, 9:59 a.m.
On Fri, Nov 8, 2013 at 3:24 AM, Cong Hou <congh@google.com> wrote:
> Ping. OK for the trunk?

Ok.

Thanks,
Richard.

>
>
>
> thanks,
> Cong
>
>
> On Fri, Nov 1, 2013 at 10:47 AM, Cong Hou <congh@google.com> wrote:
>> It seems that on some platforms the loops in
>> testsuite/gcc.dg/vect/pr58508.c may be unable to be vectorized. This
>> small patch added { dg-require-effective-target vect_int } to make
>> sure all loops can be vectorized.
>>
>>
>> thanks,
>> Cong
>>
>>
>> diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
>> index 9d0f4a5..3d9916d 100644
>> --- a/gcc/testsuite/ChangeLog
>> +++ b/gcc/testsuite/ChangeLog
>> @@ -1,3 +1,7 @@
>> +2013-10-29  Cong Hou  <congh@google.com>
>> +
>> +       * gcc.dg/vect/pr58508.c: Update.
>> +
>>  2013-10-15  Cong Hou  <congh@google.com>
>>
>>         * gcc.dg/vect/pr58508.c: New test.
>> diff --git a/gcc/testsuite/gcc.dg/vect/pr58508.c
>> b/gcc/testsuite/gcc.dg/vect/pr58508.c
>> index 6484a65..fff7a04 100644
>> --- a/gcc/testsuite/gcc.dg/vect/pr58508.c
>> +++ b/gcc/testsuite/gcc.dg/vect/pr58508.c
>> @@ -1,3 +1,4 @@
>> +/* { dg-require-effective-target vect_int } */
>>  /* { dg-do compile } */
>>  /* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */
Jakub Jelinek - Nov. 12, 2013, 2:05 p.m.
On Thu, Nov 07, 2013 at 06:24:55PM -0800, Cong Hou wrote:
> Ping. OK for the trunk?
> On Fri, Nov 1, 2013 at 10:47 AM, Cong Hou <congh@google.com> wrote:
> > It seems that on some platforms the loops in
> > testsuite/gcc.dg/vect/pr58508.c may be unable to be vectorized. This
> > small patch added { dg-require-effective-target vect_int } to make
> > sure all loops can be vectorized.
> > diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
> > index 9d0f4a5..3d9916d 100644
> > --- a/gcc/testsuite/ChangeLog
> > +++ b/gcc/testsuite/ChangeLog
> > @@ -1,3 +1,7 @@
> > +2013-10-29  Cong Hou  <congh@google.com>
> > +
> > +       * gcc.dg/vect/pr58508.c: Update.
> > +
> >  2013-10-15  Cong Hou  <congh@google.com>
> >
> >         * gcc.dg/vect/pr58508.c: New test.
> > diff --git a/gcc/testsuite/gcc.dg/vect/pr58508.c
> > b/gcc/testsuite/gcc.dg/vect/pr58508.c
> > index 6484a65..fff7a04 100644
> > --- a/gcc/testsuite/gcc.dg/vect/pr58508.c
> > +++ b/gcc/testsuite/gcc.dg/vect/pr58508.c
> > @@ -1,3 +1,4 @@
> > +/* { dg-require-effective-target vect_int } */
> >  /* { dg-do compile } */
> >  /* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */

This isn't the only bug in the testcase.  Another one is using
dg-options in gcc.dg/vect/, you should just leave that out,
the default options already include those options, but explicit dg-options
mean that other required options like -msse2 on i?86 aren't added.

	Jakub

Patch

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 9d0f4a5..3d9916d 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,7 @@ 
+2013-10-29  Cong Hou  <congh@google.com>
+
+       * gcc.dg/vect/pr58508.c: Update.
+
 2013-10-15  Cong Hou  <congh@google.com>

        * gcc.dg/vect/pr58508.c: New test.
diff --git a/gcc/testsuite/gcc.dg/vect/pr58508.c
b/gcc/testsuite/gcc.dg/vect/pr58508.c
index 6484a65..fff7a04 100644
--- a/gcc/testsuite/gcc.dg/vect/pr58508.c
+++ b/gcc/testsuite/gcc.dg/vect/pr58508.c
@@ -1,3 +1,4 @@ 
+/* { dg-require-effective-target vect_int } */
 /* { dg-do compile } */
 /* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-details" } */