Patchwork [U-Boot,v2] configs: imx: Make CONFIG_SYS_PROMPT uniform across FSL boards

login
register
mail settings
Submitter Fabio Estevam
Date Nov. 1, 2013, 10:12 a.m.
Message ID <1383300744-6538-1-git-send-email-fabio.estevam@freescale.com>
Download mbox | patch
Permalink /patch/287755/
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Comments

Fabio Estevam - Nov. 1, 2013, 10:12 a.m.
There is no real benefit in adding the board name into U-boot's prompt, so 
remove the custom CONFIG_SYS_PROMPT definitions so that the standard "=> " 
prompt is used across FSL boards.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- Remove CONFIG_SYS_PROMPT completely, instead of replacing with '=>'

 include/configs/mx25pdk.h         | 1 -
 include/configs/mx28evk.h         | 1 -
 include/configs/mx31pdk.h         | 1 -
 include/configs/mx35pdk.h         | 1 -
 include/configs/mx51evk.h         | 1 -
 include/configs/mx53evk.h         | 1 -
 include/configs/mx53loco.h        | 1 -
 include/configs/mx53smd.h         | 1 -
 include/configs/mx6qarm2.h        | 1 -
 include/configs/mx6sabre_common.h | 1 -
 10 files changed, 10 deletions(-)
Fabio Estevam - Nov. 3, 2013, 11:50 p.m.
Hi Stefano,

On Fri, Nov 1, 2013 at 8:12 AM, Fabio Estevam
<fabio.estevam@freescale.com> wrote:
> There is no real benefit in adding the board name into U-boot's prompt, so
> remove the custom CONFIG_SYS_PROMPT definitions so that the standard "=> "
> prompt is used across FSL boards.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Remove CONFIG_SYS_PROMPT completely, instead of replacing with '=>'

Forgot to mention that this patch depends on Rob's:
http://patchwork.ozlabs.org/patch/279334/

,otherwise we get build errors.

Regards,

Fabio Estevam
Stefano Babic - Nov. 4, 2013, 8:12 a.m.
Hi Fabio,

On 04/11/2013 00:50, Fabio Estevam wrote:
> Hi Stefano,
> 
> On Fri, Nov 1, 2013 at 8:12 AM, Fabio Estevam
> <fabio.estevam@freescale.com> wrote:
>> There is no real benefit in adding the board name into U-boot's prompt, so
>> remove the custom CONFIG_SYS_PROMPT definitions so that the standard "=> "
>> prompt is used across FSL boards.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>> Changes since v1:
>> - Remove CONFIG_SYS_PROMPT completely, instead of replacing with '=>'
> 
> Forgot to mention that this patch depends on Rob's:
> http://patchwork.ozlabs.org/patch/279334/
> 

Right, I am tracking Rob's patch before including yours.

Best regards,
Stefano Babic
Stefano Babic - Nov. 13, 2013, 9:12 a.m.
On 01/11/2013 11:12, Fabio Estevam wrote:
> There is no real benefit in adding the board name into U-boot's prompt, so 
> remove the custom CONFIG_SYS_PROMPT definitions so that the standard "=> " 
> prompt is used across FSL boards.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---


Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Patch

diff --git a/include/configs/mx25pdk.h b/include/configs/mx25pdk.h
index 543c415..79b36c2 100644
--- a/include/configs/mx25pdk.h
+++ b/include/configs/mx25pdk.h
@@ -65,7 +65,6 @@ 
 #define CONFIG_SYS_MMC_ENV_DEV 0
 
 /* U-Boot general configuration */
-#define CONFIG_SYS_PROMPT	"MX25PDK U-Boot > "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE	256	/* Console I/O Buffer Size  */
 /* Print buffer sz */
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
index 07f88ca..22fdb3a 100644
--- a/include/configs/mx28evk.h
+++ b/include/configs/mx28evk.h
@@ -14,7 +14,6 @@ 
 /* System configurations */
 #define CONFIG_MX28				/* i.MX28 SoC */
 #define CONFIG_MACH_TYPE	MACH_TYPE_MX28EVK
-#define CONFIG_SYS_PROMPT	"MX28EVK U-Boot > "
 
 /* U-Boot Commands */
 #define CONFIG_SYS_NO_FLASH
diff --git a/include/configs/mx31pdk.h b/include/configs/mx31pdk.h
index d41f2cd..591ab54 100644
--- a/include/configs/mx31pdk.h
+++ b/include/configs/mx31pdk.h
@@ -120,7 +120,6 @@ 
  * Miscellaneous configurable options
  */
 #define CONFIG_SYS_LONGHELP	/* undef to save memory */
-#define CONFIG_SYS_PROMPT	"MX31PDK U-Boot > "
 #define CONFIG_SYS_CBSIZE	256	/* Console I/O Buffer Size */
 /* Print Buffer Size */
 #define CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE + \
diff --git a/include/configs/mx35pdk.h b/include/configs/mx35pdk.h
index 2f59104..d72b312 100644
--- a/include/configs/mx35pdk.h
+++ b/include/configs/mx35pdk.h
@@ -136,7 +136,6 @@ 
  * Miscellaneous configurable options
  */
 #define CONFIG_SYS_LONGHELP	/* undef to save memory */
-#define CONFIG_SYS_PROMPT	"MX35 U-Boot > "
 #define CONFIG_CMDLINE_EDITING
 #define CONFIG_SYS_HUSH_PARSER	/* Use the HUSH parser */
 
diff --git a/include/configs/mx51evk.h b/include/configs/mx51evk.h
index 04f518a..4edbc4c 100644
--- a/include/configs/mx51evk.h
+++ b/include/configs/mx51evk.h
@@ -219,7 +219,6 @@ 
  */
 #define CONFIG_SYS_LONGHELP		/* undef to save memory */
 #define CONFIG_SYS_HUSH_PARSER		/* use "hush" command parser */
-#define CONFIG_SYS_PROMPT		"MX51EVK U-Boot > "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE		256	/* Console I/O Buffer Size */
 /* Print Buffer Size */
diff --git a/include/configs/mx53evk.h b/include/configs/mx53evk.h
index fe5cf3c..99c40d8 100644
--- a/include/configs/mx53evk.h
+++ b/include/configs/mx53evk.h
@@ -136,7 +136,6 @@ 
 /* Miscellaneous configurable options */
 #define CONFIG_SYS_LONGHELP		/* undef to save memory */
 #define CONFIG_SYS_HUSH_PARSER		/* use "hush" command parser */
-#define CONFIG_SYS_PROMPT		"MX53EVK U-Boot > "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE		256	/* Console I/O Buffer Size */
 
diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h
index bd2fa43..e000839 100644
--- a/include/configs/mx53loco.h
+++ b/include/configs/mx53loco.h
@@ -178,7 +178,6 @@ 
 /* Miscellaneous configurable options */
 #define CONFIG_SYS_LONGHELP		/* undef to save memory */
 #define CONFIG_SYS_HUSH_PARSER		/* use "hush" command parser */
-#define CONFIG_SYS_PROMPT		"MX53LOCO U-Boot > "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE		512	/* Console I/O Buffer Size */
 
diff --git a/include/configs/mx53smd.h b/include/configs/mx53smd.h
index 12b2c0d..a1d5b70 100644
--- a/include/configs/mx53smd.h
+++ b/include/configs/mx53smd.h
@@ -121,7 +121,6 @@ 
 /* Miscellaneous configurable options */
 #define CONFIG_SYS_LONGHELP		/* undef to save memory */
 #define CONFIG_SYS_HUSH_PARSER		/* use "hush" command parser */
-#define CONFIG_SYS_PROMPT		"MX53SMD U-Boot > "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE		256	/* Console I/O Buffer Size */
 
diff --git a/include/configs/mx6qarm2.h b/include/configs/mx6qarm2.h
index ef3058c..d759de7 100644
--- a/include/configs/mx6qarm2.h
+++ b/include/configs/mx6qarm2.h
@@ -114,7 +114,6 @@ 
 /* Miscellaneous configurable options */
 #define CONFIG_SYS_LONGHELP
 #define CONFIG_SYS_HUSH_PARSER
-#define CONFIG_SYS_PROMPT		"MX6QARM2 U-Boot > "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE		256
 
diff --git a/include/configs/mx6sabre_common.h b/include/configs/mx6sabre_common.h
index bf6113b..0fb8e0b 100644
--- a/include/configs/mx6sabre_common.h
+++ b/include/configs/mx6sabre_common.h
@@ -171,7 +171,6 @@ 
 #define CONFIG_SYS_LONGHELP
 #define CONFIG_SYS_HUSH_PARSER
 #define CONFIG_SYS_PROMPT_HUSH_PS2     "> "
-#define CONFIG_SYS_PROMPT              "U-Boot > "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE              256