From patchwork Fri Nov 1 09:54:32 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Michael_B=C3=BCsch?= X-Patchwork-Id: 287751 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9A9BA2C0095 for ; Fri, 1 Nov 2013 20:56:06 +1100 (EST) Received: from localhost ([::1]:36930 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VcBSU-0003cq-1c for incoming@patchwork.ozlabs.org; Fri, 01 Nov 2013 05:56:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VcBSB-0003ch-A7 for qemu-devel@nongnu.org; Fri, 01 Nov 2013 05:55:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VcBS3-0004HE-DI for qemu-devel@nongnu.org; Fri, 01 Nov 2013 05:55:43 -0400 Received: from cl-3366.cgn-01.de.sixxs.net ([2001:4dd0:ff00:d25::2]:60535 helo=bues.ch) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VcBS3-0004GD-6v for qemu-devel@nongnu.org; Fri, 01 Nov 2013 05:55:35 -0400 Received: by bues.ch with esmtpsa (Exim 4.80) (envelope-from ) id 1VcBRm-0001ZF-8V; Fri, 01 Nov 2013 10:55:18 +0100 Date: Fri, 1 Nov 2013 10:54:32 +0100 From: Michael =?UTF-8?B?QsO8c2No?= To: Michael Tokarev Message-ID: <20131101105432.5f45f689@wiggum> In-Reply-To: <52737541.3030802@msgid.tls.msk.ru> References: <20131026090745.14894.51156.reportbug@localhost> <526B8921.3060605@msgid.tls.msk.ru> <20131026184443.7b1293d8@wiggum> <52737541.3030802@msgid.tls.msk.ru> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.22; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4dd0:ff00:d25::2 Cc: 727756@bugs.debian.org, qemu-devel Subject: Re: [Qemu-devel] Bug#727756: qemu: Broken -smb with latest SAMBA package. (Unsupported security=share option) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Fri, 01 Nov 2013 13:32:49 +0400 Michael Tokarev wrote: > That looks right. Are you okay adding your Signed-off-by to the patch > you initially submitted? If yes, I'll make a formal patch submission > upstream. Here you go. From: Michael Buesch Subject: [PATCH] qemu/slirp: Fix SMB security configuration on newer samba versions The smb.conf automatically generated by qemu's -smb option fails on current samba, because smbd rejects the security=share option with the following warning: > WARNING: Ignoring invalid value 'share' for parameter 'security' Which makes it fall back to security=user without guest login. This results in being unable to login to the samba server from the guest OS. This fixes it by selecting 'user' explicitly and mapping unknown users to guest logins. Signed-off-by: Michael Buesch --- Index: qemu-1.6.0+dfsg/net/slirp.c =================================================================== --- qemu-1.6.0+dfsg.orig/net/slirp.c +++ qemu-1.6.0+dfsg/net/slirp.c @@ -529,7 +529,8 @@ static int slirp_smb(SlirpState* s, cons "state directory=%s\n" "log file=%s/log.smbd\n" "smb passwd file=%s/smbpasswd\n" - "security = share\n" + "security = user\n" + "map to guest = Bad User\n" "[qemu]\n" "path=%s\n" "read only=no\n"