From patchwork Thu Oct 31 20:21:55 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 287604 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A2C1B2C03F8 for ; Fri, 1 Nov 2013 07:26:31 +1100 (EST) Received: from localhost ([::1]:59172 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vbyp3-0006lM-MU for incoming@patchwork.ozlabs.org; Thu, 31 Oct 2013 16:26:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53095) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbylA-0002fW-KI for qemu-devel@nongnu.org; Thu, 31 Oct 2013 16:22:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vbyl4-0000Pa-R0 for qemu-devel@nongnu.org; Thu, 31 Oct 2013 16:22:28 -0400 Received: from mail-pb0-x22f.google.com ([2607:f8b0:400e:c01::22f]:42748) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vbyl4-0000OJ-K4 for qemu-devel@nongnu.org; Thu, 31 Oct 2013 16:22:22 -0400 Received: by mail-pb0-f47.google.com with SMTP id rq2so3287040pbb.20 for ; Thu, 31 Oct 2013 13:22:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=QT2XvuH5lK/VpCcOdqhHJUQ4oMXowZP9REs7nj0Op3o=; b=RheqYC9aMj2/vyaz6RnkJ70DbDc8gzJ1XPXDq3mmz0Uhq3tNy97KG7mCjSqd/Z1FgA a+ZtqvDPgpQN4zpQOZIxS7FlkGI7nwWVkK5O0QBoeqaI34/ndMmDPO1SYD9frvp/mZ3n 0EM7fGubAEPmvgpCpzW8Qqi9LB/KguPqw7rBAAqQHCBRbHii2ESal5cRggVYcQOi+sw5 IXXjDRLITz8usNOFQ0EAGldgSXvoAhpKt4zROgCeTX+DY/b06WyBldRKE3g8yziK6GUh hSbq585jmlotULFYfLDKfsYiXgc4B8mYWvnGIA9nbu2O4zWCLkyTsuiqVB1om4+uddcV HE/w== X-Received: by 10.66.136.227 with SMTP id qd3mr3729793pab.113.1383250941739; Thu, 31 Oct 2013 13:22:21 -0700 (PDT) Received: from pebble.twiddle.net (50-194-63-110-static.hfc.comcastbusiness.net. [50.194.63.110]) by mx.google.com with ESMTPSA id ve9sm6109179pbc.19.2013.10.31.13.22.20 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 31 Oct 2013 13:22:21 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Thu, 31 Oct 2013 13:21:55 -0700 Message-Id: <1383250929-10288-7-git-send-email-rth@twiddle.net> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1383250929-10288-1-git-send-email-rth@twiddle.net> References: <1383250929-10288-1-git-send-email-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c01::22f Cc: aliguori@amazon.com, aurelien@aurel32.net Subject: [Qemu-devel] [PATCH 06/20] tcg-ia64: Avoid unnecessary stop bit in tcg_out_alu X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org When performing an operation with two input registers, we'd leave the stop bit (and thus an extra cycle) that's only needed when one or the other input is a constant. Signed-off-by: Richard Henderson Acked-by: Aurelien Jarno --- tcg/ia64/tcg-target.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c index 336781f..b7f74a9 100644 --- a/tcg/ia64/tcg-target.c +++ b/tcg/ia64/tcg-target.c @@ -1044,31 +1044,26 @@ static inline void tcg_out_st(TCGContext *s, TCGType type, TCGReg arg, } } -static inline void tcg_out_alu(TCGContext *s, uint64_t opc_a1, TCGArg ret, - TCGArg arg1, int const_arg1, - TCGArg arg2, int const_arg2) +static void tcg_out_alu(TCGContext *s, uint64_t opc_a1, TCGReg ret, TCGArg arg1, + int const_arg1, TCGArg arg2, int const_arg2) { - uint64_t opc1, opc2; + uint64_t opc1 = 0, opc2 = 0; if (const_arg1 && arg1 != 0) { opc1 = tcg_opc_a5(TCG_REG_P0, OPC_ADDL_A5, TCG_REG_R2, arg1, TCG_REG_R0); arg1 = TCG_REG_R2; - } else { - opc1 = INSN_NOP_M; } if (const_arg2 && arg2 != 0) { opc2 = tcg_opc_a5(TCG_REG_P0, OPC_ADDL_A5, TCG_REG_R3, arg2, TCG_REG_R0); arg2 = TCG_REG_R3; - } else { - opc2 = INSN_NOP_I; } - tcg_out_bundle(s, mII, - opc1, - opc2, + tcg_out_bundle(s, (opc1 || opc2 ? mII : miI), + opc1 ? opc1 : INSN_NOP_M, + opc2 ? opc2 : INSN_NOP_I, tcg_opc_a1(TCG_REG_P0, opc_a1, ret, arg1, arg2)); }