Patchwork [6/7] block: qemu-iotests, add quotes to $TEST_IMG usage for 051

login
register
mail settings
Submitter Jeff Cody
Date Oct. 31, 2013, 3:57 p.m.
Message ID <6d7cc5b7b07769b9a733a4f8b99d54ff22ae3280.1383231037.git.jcody@redhat.com>
Download mbox | patch
Permalink /patch/287561/
State New
Headers show

Comments

Jeff Cody - Oct. 31, 2013, 3:57 p.m.
There were still a couple of instances of unquoted usage of
$TEST_IMG and $TEST_IMG.orig.  Quoted these so they will not fail
on pathnames with spaces in them.

Signed-off-by: Jeff Cody <jcody@redhat.com>
---
 tests/qemu-iotests/051 | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Eric Blake - Oct. 31, 2013, 5:03 p.m.
On 10/31/2013 09:57 AM, Jeff Cody wrote:
> There were still a couple of instances of unquoted usage of
> $TEST_IMG and $TEST_IMG.orig.  Quoted these so they will not fail
> on pathnames with spaces in them.
> 
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
>  tests/qemu-iotests/051 | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

Patch

diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051
index 356c375..0a4971d 100755
--- a/tests/qemu-iotests/051
+++ b/tests/qemu-iotests/051
@@ -64,9 +64,9 @@  function run_qemu()
 size=128M
 
 _make_test_img $size
-cp $TEST_IMG $TEST_IMG.orig
-mv $TEST_IMG $TEST_IMG.base
-_make_test_img -b $TEST_IMG.base $size
+cp "$TEST_IMG" "$TEST_IMG.orig"
+mv "$TEST_IMG" "$TEST_IMG.base"
+_make_test_img -b "$TEST_IMG.base" $size
 
 echo
 echo === Unknown option ===
@@ -81,7 +81,7 @@  echo
 echo === Overriding backing file ===
 echo
 
-echo "info block" | run_qemu -drive file=$TEST_IMG,driver=qcow2,backing.file.filename=$TEST_IMG.orig -nodefaults
+echo "info block" | run_qemu -drive file="$TEST_IMG",driver=qcow2,backing.file.filename="$TEST_IMG.orig" -nodefaults
 
 echo
 echo === Enable and disable lazy refcounting on the command line, plus some invalid values ===