From patchwork Thu Oct 31 14:30:04 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Michael S. Tsirkin" X-Patchwork-Id: 287501 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 80C6D2C03E5 for ; Fri, 1 Nov 2013 01:27:56 +1100 (EST) Received: from localhost ([::1]:57338 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbtE1-00052x-0Q for incoming@patchwork.ozlabs.org; Thu, 31 Oct 2013 10:27:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54048) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbtDf-00051o-F1 for qemu-devel@nongnu.org; Thu, 31 Oct 2013 10:27:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbtDX-0003vj-LO for qemu-devel@nongnu.org; Thu, 31 Oct 2013 10:27:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21385) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbtDX-0003vf-D1 for qemu-devel@nongnu.org; Thu, 31 Oct 2013 10:27:23 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9VERF4B026628 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 31 Oct 2013 10:27:15 -0400 Received: from redhat.com (vpn1-5-193.ams2.redhat.com [10.36.5.193]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with SMTP id r9VER9Ca020704; Thu, 31 Oct 2013 10:27:10 -0400 Date: Thu, 31 Oct 2013 16:30:04 +0200 From: "Michael S. Tsirkin" To: Hu Tao Message-ID: <20131031143004.GA9948@redhat.com> References: <1377187852-11192-1-git-send-email-pbonzini@redhat.com> <20131024023903.GD16757@G08FNSTD100614.fnst.cn.fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131024023903.GD16757@G08FNSTD100614.fnst.cn.fujitsu.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: pkrempa@redhat.com, marcel.a@redhat.com, libvir-list@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, rhod@redhat.com, kraxel@redhat.com, anthony@codemonkey.ws, Paolo Bonzini , lcapitulino@redhat.com, afaerber@suse.de Subject: Re: [Qemu-devel] pvpanic plans? X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote: > Hi All, > > I know it's been a long time since this thread. But qemu 1.7 is > releasing, do you have any consensus on this? > > Thanks. I think the biggest issue is the new PANICKED state. Guests already have simple ways to halt the CPU, and actually do. I think a new state was a mistake. So how about the following? Does it break anything? (Untested). Signed-off-by: Michael S. Tsirkin diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c index 226e298..2055afc 100644 --- a/hw/misc/pvpanic.c +++ b/hw/misc/pvpanic.c @@ -51,7 +51,6 @@ static void handle_event(int event) if (event & PVPANIC_PANICKED) { panicked_mon_event("pause"); - vm_stop(RUN_STATE_GUEST_PANICKED); return; } }