diff mbox

[U-Boot,1/2,V3] esdhc: memset mmc struct before putting into use

Message ID 1383183499-16052-1-git-send-email-Haijun.Zhang@freescale.com
State Accepted
Delegated to: Pantelis Antoniou
Headers show

Commit Message

Haijun.Zhang Oct. 31, 2013, 1:38 a.m. UTC 
struct mmc should be clear to all '0' after malloc to avoid
unexpect variable value.

Like mmc->has_init = xxx.
In this case mmcinfo will believe the card had been initialized before
and skip the initialization.

Test on P5040 and T4240,
Error Log:

=> mmcinfo
Device: FSL_SDHC
Manufacturer ID: 0
OEM: 0
Name: Tran Speed: 0
Rd Block Len: 0
MMC version 0.0
High Capacity: No
Capacity: 0 Bytes
Bus Width: 0-bit
=>

Signed-off-by: Haijun Zhang <Haijun.Zhang@freescale.com>
Signed-off-by: Xie Shaohui-B21989 <B21989@freescale.com>
Tested-by: Ryan Barnett <rjbarnet@rockwellcollins.com>
---
changes for V3:
	- Only add Tested-by no other changes
changes for V2:
	- No changes

 drivers/mmc/fsl_esdhc.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Pantelis Antoniou Oct. 31, 2013, 7:53 a.m. UTC | #1 
Hi Haijun,

On Oct 31, 2013, at 3:38 AM, Haijun Zhang wrote:

> struct mmc should be clear to all '0' after malloc to avoid
> unexpect variable value.
> 
> Like mmc->has_init = xxx.
> In this case mmcinfo will believe the card had been initialized before
> and skip the initialization.
> 
> Test on P5040 and T4240,
> Error Log:
> 
> => mmcinfo
> Device: FSL_SDHC
> Manufacturer ID: 0
> OEM: 0
> Name: Tran Speed: 0
> Rd Block Len: 0
> MMC version 0.0
> High Capacity: No
> Capacity: 0 Bytes
> Bus Width: 0-bit
> =>
> 
> Signed-off-by: Haijun Zhang <Haijun.Zhang@freescale.com>
> Signed-off-by: Xie Shaohui-B21989 <B21989@freescale.com>
> Tested-by: Ryan Barnett <rjbarnet@rockwellcollins.com>
> ---
> changes for V3:
> 	- Only add Tested-by no other changes
> changes for V2:
> 	- No changes
> 
> drivers/mmc/fsl_esdhc.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
> index a7170b4..d4c1eef 100644
> --- a/drivers/mmc/fsl_esdhc.c
> +++ b/drivers/mmc/fsl_esdhc.c
> @@ -521,6 +521,7 @@ int fsl_esdhc_initialize(bd_t *bis, struct fsl_esdhc_cfg *cfg)
> 	if (!mmc)
> 		return -ENOMEM;
> 
> +	memset(mmc, 0, sizeof(struct mmc));
> 	sprintf(mmc->name, "FSL_SDHC");
> 	regs = (struct fsl_esdhc *)cfg->esdhc_base;
> 
> -- 
> 1.8.4
> 
> 

Applied, thanks.

Acked-by: Pantelis Antoniou <panto@antoniou-consulting.com>
diff mbox

Patch

diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
index a7170b4..d4c1eef 100644
--- a/drivers/mmc/fsl_esdhc.c
+++ b/drivers/mmc/fsl_esdhc.c
@@ -521,6 +521,7 @@  int fsl_esdhc_initialize(bd_t *bis, struct fsl_esdhc_cfg *cfg)
 	if (!mmc)
 		return -ENOMEM;
 
+	memset(mmc, 0, sizeof(struct mmc));
 	sprintf(mmc->name, "FSL_SDHC");
 	regs = (struct fsl_esdhc *)cfg->esdhc_base;