| Message ID | eb3ff54b0906160150n74fb8984u84a366f5e472b4c3@mail.gmail.com |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Rami Rosen <ramirose@gmail.com> Date: Tue, 16 Jun 2009 11:50:11 +0300 > This cleanup patch removes an unused union (header) in udp_skb_cb. > (include/net/udp.h) It is used Rami. The layer above UDP packet processing used IPSKB() and the ipv6 variant (I forget what it's called) so we have to take care not to write over that layer's recorded values in the skb->cb[] -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, Sorry, I forgot that besides UDP_SKB_CB() also the IPSKB() macro can access the cb. >The layer above UDP packet processing used > IPSKB() and the ipv6 variant (I forget what it's called) BTW, it is IP6CB() in IPV6 Regards, Rami Rosen On Tue, Jun 16, 2009 at 12:40 PM, David Miller<davem@davemloft.net> wrote: > From: Rami Rosen <ramirose@gmail.com> > Date: Tue, 16 Jun 2009 11:50:11 +0300 > >> This cleanup patch removes an unused union (header) in udp_skb_cb. >> (include/net/udp.h) > > It is used Rami. The layer above UDP packet processing used > IPSKB() and the ipv6 variant (I forget what it's called) so > we have to take care not to write over that layer's recorded > values in the skb->cb[] > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/net/udp.h b/include/net/udp.h index 90e6ce5..fb3031b 100644 --- a/include/net/udp.h +++ b/include/net/udp.h @@ -34,17 +34,10 @@ /** * struct udp_skb_cb - UDP(-Lite) private variables * - * @header: private variables used by IPv4/IPv6 * @cscov: checksum coverage length (UDP-Lite only) * @partial_cov: if set indicates partial csum coverage */ struct udp_skb_cb { - union { - struct inet_skb_parm h4; -#if defined(CONFIG_IPV6) || defined (CONFIG_IPV6_MODULE) - struct inet6_skb_parm h6; -#endif - } header; __u16 cscov; __u8 partial_cov; };
Hi, This cleanup patch removes an unused union (header) in udp_skb_cb. (include/net/udp.h) Regards, Rami Rosen Signed-off-by: Rami Rosen <ramirose@gmail.com>