Patchwork [v2,10/19] mtd: sh_flctl: Enable the driver on all ARM platforms

login
register
mail settings
Submitter Laurent Pinchart
Date Oct. 29, 2013, 10:37 p.m.
Message ID <1383086274-11049-11-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
Download mbox | patch
Permalink /patch/287074/
State New
Headers show

Comments

Laurent Pinchart - Oct. 29, 2013, 10:37 p.m.
Renesas ARM platforms are transitioning from single-platform to
multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the
driver available on all ARM platforms to enable it on both ARCH_SHMOBILE
and ARCH_SHMOBILE_MULTI, and increase build testing coverage with
COMPILE_TEST.

Cc: David Woodhouse <dwmw2@infradead.org>
Cc: linux-mtd@lists.infradead.org
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 drivers/mtd/nand/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Brian Norris - Nov. 12, 2013, 11:10 p.m.
On Tue, Oct 29, 2013 at 11:37:45PM +0100, Laurent Pinchart wrote:
> Renesas ARM platforms are transitioning from single-platform to
> multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the
> driver available on all ARM platforms to enable it on both ARCH_SHMOBILE
> and ARCH_SHMOBILE_MULTI, and increase build testing coverage with
> COMPILE_TEST.
> 
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: linux-mtd@lists.infradead.org
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Applied to l2-mtd.git, branch 'next' (for 3.14). Thanks.

Brian
Laurent Pinchart - Nov. 12, 2013, 11:14 p.m.
Hi Brian,

On Tuesday 12 November 2013 15:10:20 Brian Norris wrote:
> On Tue, Oct 29, 2013 at 11:37:45PM +0100, Laurent Pinchart wrote:
> > Renesas ARM platforms are transitioning from single-platform to
> > multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the
> > driver available on all ARM platforms to enable it on both ARCH_SHMOBILE
> > and ARCH_SHMOBILE_MULTI, and increase build testing coverage with
> > COMPILE_TEST.
> > 
> > Cc: David Woodhouse <dwmw2@infradead.org>
> > Cc: linux-mtd@lists.infradead.org
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> 
> Applied to l2-mtd.git, branch 'next' (for 3.14). Thanks.

Thank you, but if it's not too late, can you drop the patch ? :-) We've 
settled for a different approach that renames Kconfig symbols and doesn't 
require changes to individual drivers.
Brian Norris - Nov. 12, 2013, 11:17 p.m.
On Wed, Nov 13, 2013 at 12:14:37AM +0100, Laurent Pinchart wrote:
> On Tuesday 12 November 2013 15:10:20 Brian Norris wrote:
> > On Tue, Oct 29, 2013 at 11:37:45PM +0100, Laurent Pinchart wrote:
> > > Renesas ARM platforms are transitioning from single-platform to
> > > multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the
> > > driver available on all ARM platforms to enable it on both ARCH_SHMOBILE
> > > and ARCH_SHMOBILE_MULTI, and increase build testing coverage with
> > > COMPILE_TEST.
> > > 
> > > Cc: David Woodhouse <dwmw2@infradead.org>
> > > Cc: linux-mtd@lists.infradead.org
> > > Signed-off-by: Laurent Pinchart
> > > <laurent.pinchart+renesas@ideasonboard.com>
> > 
> > Applied to l2-mtd.git, branch 'next' (for 3.14). Thanks.
> 
> Thank you, but if it's not too late, can you drop the patch ? :-) We've 
> settled for a different approach that renames Kconfig symbols and doesn't 
> require changes to individual drivers.

No problem. It's dropped.

I was only paying attention to the cover letter, where that decision
apparently didn't show up :)

Brian
Laurent Pinchart - Nov. 12, 2013, 11:20 p.m.
Hi Brian,

On Tuesday 12 November 2013 15:17:19 Brian Norris wrote:
> On Wed, Nov 13, 2013 at 12:14:37AM +0100, Laurent Pinchart wrote:
> > On Tuesday 12 November 2013 15:10:20 Brian Norris wrote:
> > > On Tue, Oct 29, 2013 at 11:37:45PM +0100, Laurent Pinchart wrote:
> > > > Renesas ARM platforms are transitioning from single-platform to
> > > > multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the
> > > > driver available on all ARM platforms to enable it on both
> > > > ARCH_SHMOBILE
> > > > and ARCH_SHMOBILE_MULTI, and increase build testing coverage with
> > > > COMPILE_TEST.
> > > > 
> > > > Cc: David Woodhouse <dwmw2@infradead.org>
> > > > Cc: linux-mtd@lists.infradead.org
> > > > Signed-off-by: Laurent Pinchart
> > > > <laurent.pinchart+renesas@ideasonboard.com>
> > > 
> > > Applied to l2-mtd.git, branch 'next' (for 3.14). Thanks.
> > 
> > Thank you, but if it's not too late, can you drop the patch ? :-) We've
> > settled for a different approach that renames Kconfig symbols and doesn't
> > require changes to individual drivers.
> 
> No problem. It's dropped.

Thank you.

> I was only paying attention to the cover letter, where that decision
> apparently didn't show up :)

I'll reply to the cover letter. Sorry about that.

Patch

diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index d885298..bc6bf36 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -486,7 +486,7 @@  config MTD_NAND_MXC
 
 config MTD_NAND_SH_FLCTL
 	tristate "Support for NAND on Renesas SuperH FLCTL"
-	depends on SUPERH || ARCH_SHMOBILE
+	depends on SUPERH || ARM || COMPILE_TEST
 	help
 	  Several Renesas SuperH CPU has FLCTL. This option enables support
 	  for NAND Flash using FLCTL.