| Message ID | 1383082053-12405-1-git-send-email-laurent.navet@gmail.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
On 10/29/2013 02:27 PM, Laurent Navet wrote: > Mac address validity is already checked in of_get_mac_address(). > No need to do it twice. > > Signed-off-by: Laurent Navet <laurent.navet@gmail.com> Luka already sent this exact patch, and I acked his. No need to do it twice. David Daney > --- > drivers/net/ethernet/octeon/octeon_mgmt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/octeon/octeon_mgmt.c b/drivers/net/ethernet/octeon/octeon_mgmt.c > index 622aa75..1b326cbc 100644 > --- a/drivers/net/ethernet/octeon/octeon_mgmt.c > +++ b/drivers/net/ethernet/octeon/octeon_mgmt.c > @@ -1545,7 +1545,7 @@ static int octeon_mgmt_probe(struct platform_device *pdev) > > mac = of_get_mac_address(pdev->dev.of_node); > > - if (mac && is_valid_ether_addr(mac)) > + if (mac) > memcpy(netdev->dev_addr, mac, ETH_ALEN); > else > eth_hw_addr_random(netdev); > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/octeon/octeon_mgmt.c b/drivers/net/ethernet/octeon/octeon_mgmt.c index 622aa75..1b326cbc 100644 --- a/drivers/net/ethernet/octeon/octeon_mgmt.c +++ b/drivers/net/ethernet/octeon/octeon_mgmt.c @@ -1545,7 +1545,7 @@ static int octeon_mgmt_probe(struct platform_device *pdev) mac = of_get_mac_address(pdev->dev.of_node); - if (mac && is_valid_ether_addr(mac)) + if (mac) memcpy(netdev->dev_addr, mac, ETH_ALEN); else eth_hw_addr_random(netdev);
Mac address validity is already checked in of_get_mac_address(). No need to do it twice. Signed-off-by: Laurent Navet <laurent.navet@gmail.com> --- drivers/net/ethernet/octeon/octeon_mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)