| Message ID | 1383081906-12342-1-git-send-email-laurent.navet@gmail.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
Dear Laurent Navet, On Tue, 29 Oct 2013 22:25:06 +0100, Laurent Navet wrote: > Mac address validity is already checked in of_get_mac_address(). > No need to do it twice. > > Signed-off-by: Laurent Navet <laurent.navet@gmail.com> Thanks, but an identical patch has been posted by Luka Perkov <luka@openwrt.org> just a few days ago. See http://www.spinics.net/lists/netdev/msg255454.html. Thanks, Thomas
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index e35bac7..7d99e695 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -2811,7 +2811,7 @@ static int mvneta_probe(struct platform_device *pdev) } dt_mac_addr = of_get_mac_address(dn); - if (dt_mac_addr && is_valid_ether_addr(dt_mac_addr)) { + if (dt_mac_addr) { mac_from = "device tree"; memcpy(dev->dev_addr, dt_mac_addr, ETH_ALEN); } else {
Mac address validity is already checked in of_get_mac_address(). No need to do it twice. Signed-off-by: Laurent Navet <laurent.navet@gmail.com> --- drivers/net/ethernet/marvell/mvneta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)