| Message ID | 20131029110134.31547.86550.stgit@deepthi.in.ibm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On 10/29/2013 12:01 PM, Deepthi Dharwar wrote: > Currently pseries_idle cpuidle backend driver cannot be > built as a module due to dependencies. Therefore the driver has > to be built in. The dependency is around update_snooze_delay() defined > in cpuidle driver and called from kernel/sysfs.c. > This patch is removes all the module related code. > > Signed-off-by: Deepthi Dharwar <deepthi@linux.vnet.ibm.com> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > drivers/cpuidle/cpuidle-ibm-power.c | 15 +-------------- > 1 file changed, 1 insertion(+), 14 deletions(-) > > diff --git a/drivers/cpuidle/cpuidle-ibm-power.c b/drivers/cpuidle/cpuidle-ibm-power.c > index faf8cc1..8c9e42c 100644 > --- a/drivers/cpuidle/cpuidle-ibm-power.c > +++ b/drivers/cpuidle/cpuidle-ibm-power.c > @@ -292,17 +292,4 @@ static int __init pseries_processor_idle_init(void) > return 0; > } > > -static void __exit pseries_processor_idle_exit(void) > -{ > - > - unregister_cpu_notifier(&setup_hotplug_notifier); > - cpuidle_unregister(&pseries_idle_driver); > - return; > -} > - > -module_init(pseries_processor_idle_init); > -module_exit(pseries_processor_idle_exit); > - > -MODULE_AUTHOR("Deepthi Dharwar <deepthi@linux.vnet.ibm.com>"); > -MODULE_DESCRIPTION("Cpuidle driver for POWER"); > -MODULE_LICENSE("GPL"); > +device_initcall(pseries_processor_idle_init); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
diff --git a/drivers/cpuidle/cpuidle-ibm-power.c b/drivers/cpuidle/cpuidle-ibm-power.c index faf8cc1..8c9e42c 100644 --- a/drivers/cpuidle/cpuidle-ibm-power.c +++ b/drivers/cpuidle/cpuidle-ibm-power.c @@ -292,17 +292,4 @@ static int __init pseries_processor_idle_init(void) return 0; } -static void __exit pseries_processor_idle_exit(void) -{ - - unregister_cpu_notifier(&setup_hotplug_notifier); - cpuidle_unregister(&pseries_idle_driver); - return; -} - -module_init(pseries_processor_idle_init); -module_exit(pseries_processor_idle_exit); - -MODULE_AUTHOR("Deepthi Dharwar <deepthi@linux.vnet.ibm.com>"); -MODULE_DESCRIPTION("Cpuidle driver for POWER"); -MODULE_LICENSE("GPL"); +device_initcall(pseries_processor_idle_init);
Currently pseries_idle cpuidle backend driver cannot be built as a module due to dependencies. Therefore the driver has to be built in. The dependency is around update_snooze_delay() defined in cpuidle driver and called from kernel/sysfs.c. This patch is removes all the module related code. Signed-off-by: Deepthi Dharwar <deepthi@linux.vnet.ibm.com> --- drivers/cpuidle/cpuidle-ibm-power.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-)